refactor(nodes): share node id matcher

src/cli/nodes-cli/rpc.ts

@@ -1,6 +1,7 @@
 import type { Command } from "commander";
 import type { NodeListNode, NodesRpcOpts } from "./types.js";
 import { callGateway } from "../../gateway/call.js";
+import { resolveNodeIdFromCandidates } from "../../shared/node-match.js";
 import { GATEWAY_CLIENT_MODES, GATEWAY_CLIENT_NAMES } from "../../utils/message-channel.js";
 import { withProgress } from "../progress.js";
 import { parseNodeList, parsePairingList } from "./format.js";
@@ -47,14 +48,6 @@ export function unauthorizedHintForMessage(message: string): string | null {
   return null;
 }
 
-function normalizeNodeKey(value: string) {
-  return value
-    .toLowerCase()
-    .replace(/[^a-z0-9]+/g, "-")
-    .replace(/^-+/, "")
-    .replace(/-+$/, "");
-}
-
 export async function resolveNodeId(opts: NodesRpcOpts, query: string) {
   const q = String(query ?? "").trim();
   if (!q) {
@@ -76,38 +69,5 @@ export async function resolveNodeId(opts: NodesRpcOpts, query: string) {
       remoteIp: n.remoteIp,
     }));
   }
-
-  const qNorm = normalizeNodeKey(q);
-  const matches = nodes.filter((n) => {
-    if (n.nodeId === q) {
-      return true;
-    }
-    if (typeof n.remoteIp === "string" && n.remoteIp === q) {
-      return true;
-    }
-    const name = typeof n.displayName === "string" ? n.displayName : "";
-    if (name && normalizeNodeKey(name) === qNorm) {
-      return true;
-    }
-    if (q.length >= 6 && n.nodeId.startsWith(q)) {
-      return true;
-    }
-    return false;
-  });
-
-  if (matches.length === 1) {
-    return matches[0].nodeId;
-  }
-  if (matches.length === 0) {
-    const known = nodes
-      .map((n) => n.displayName || n.remoteIp || n.nodeId)
-      .filter(Boolean)
-      .join(", ");
-    throw new Error(`unknown node: ${q}${known ? ` (known: ${known})` : ""}`);
-  }
-  throw new Error(
-    `ambiguous node: ${q} (matches: ${matches
-      .map((n) => n.displayName || n.remoteIp || n.nodeId)
-      .join(", ")})`,
-  );
+  return resolveNodeIdFromCandidates(nodes, q);
 }