From 177f167eab203c659bb759dfb70eb8eba86d3c9d Mon Sep 17 00:00:00 2001
From: Omair Afzal <32237905+omair445@users.noreply.github.com>
Date: Tue, 24 Feb 2026 08:22:39 +0500
Subject: [PATCH] fix: guard .trim() calls on potentially undefined
 workspaceDir (#24875)

Change workspaceDir param type from string to string | undefined in
resolvePluginSkillDirs and use nullish coalescing before .trim() to
prevent TypeError when workspaceDir is undefined.
---
 src/agents/skills/plugin-skills.ts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/agents/skills/plugin-skills.ts b/src/agents/skills/plugin-skills.ts
index c3e7999fe..90c8711cd 100644
--- a/src/agents/skills/plugin-skills.ts
+++ b/src/agents/skills/plugin-skills.ts
@@ -12,10 +12,10 @@ import { loadPluginManifestRegistry } from "../../plugins/manifest-registry.js";
 const log = createSubsystemLogger("skills");
 
 export function resolvePluginSkillDirs(params: {
-  workspaceDir: string;
+  workspaceDir: string | undefined;
   config?: OpenClawConfig;
 }): string[] {
-  const workspaceDir = params.workspaceDir.trim();
+  const workspaceDir = (params.workspaceDir ?? "").trim();
   if (!workspaceDir) {
     return [];
   }