From 4c1424bb839914cf7112222d0d148665fdef3ed0 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Thu, 1 Jan 2026 21:25:29 +0100
Subject: [PATCH] chore: fix lint warnings

---
 CHANGELOG.md                   |  1 +
 src/browser/pw-session.ts      | 11 ++++++++---
 src/browser/pw-tools-core.ts   |  2 +-
 src/commands/onboard-auth.ts   |  4 ++--
 src/commands/onboard-skills.ts |  2 +-
 src/signal/monitor.ts          |  2 +-
 6 files changed, 14 insertions(+), 8 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e49fdc74a..d2e4412ff 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -33,6 +33,7 @@
 - macOS: prioritize main bundle for device resources to prevent crash (#73) — thanks @petter-b
 - macOS remote: route settings through gateway config and avoid local config reads in remote mode.
 - Telegram: align token resolution for cron/agent/CLI sends (env/config/tokenFile) to prevent isolated delivery failures (#76).
+- Tooling: clean up lint warnings in onboarding, browser, and signal paths.
 - Chat UI: clear composer input immediately and allow clear while editing to prevent duplicate sends (#72) — thanks @hrdwdmrbl
 - Restart: use systemd on Linux (and report actual restart method) instead of always launchctl.
 - Gateway relay: detect Bun binaries via execPath to resolve packaged assets on macOS.
diff --git a/src/browser/pw-session.ts b/src/browser/pw-session.ts
index 18f34f110..d9d7f3fb3 100644
--- a/src/browser/pw-session.ts
+++ b/src/browser/pw-session.ts
@@ -5,6 +5,7 @@ import type {
   Page,
 } from "playwright-core";
 import { chromium } from "playwright-core";
+import { formatErrorMessage } from "../infra/errors.js";
 
 export type BrowserConsoleMessage = {
   type: string;
@@ -119,9 +120,13 @@ async function connectBrowser(endpoint: string): Promise<ConnectedBrowser> {
         await new Promise((r) => setTimeout(r, delay));
       }
     }
-    throw lastErr instanceof Error
-      ? lastErr
-      : new Error(String(lastErr ?? "CDP connect failed"));
+    if (lastErr instanceof Error) {
+      throw lastErr;
+    }
+    const message = lastErr
+      ? formatErrorMessage(lastErr)
+      : "CDP connect failed";
+    throw new Error(message);
   };
 
   connecting = connectWithRetry().finally(() => {
diff --git a/src/browser/pw-tools-core.ts b/src/browser/pw-tools-core.ts
index 99f1507eb..d08c0805e 100644
--- a/src/browser/pw-tools-core.ts
+++ b/src/browser/pw-tools-core.ts
@@ -286,7 +286,7 @@ export async function armFileUploadViaPlaywright(opts: {
       try {
         const input =
           typeof fileChooser.element === "function"
-            ? await fileChooser.element()
+            ? await Promise.resolve(fileChooser.element())
             : null;
         if (input) {
           await input.evaluate((el) => {
diff --git a/src/commands/onboard-auth.ts b/src/commands/onboard-auth.ts
index bf3e257ba..23e35d018 100644
--- a/src/commands/onboard-auth.ts
+++ b/src/commands/onboard-auth.ts
@@ -39,11 +39,11 @@ export function applyMinimaxConfig(cfg: ClawdisConfig): ClawdisConfig {
   allowed.add("anthropic/claude-opus-4-5");
   allowed.add("lmstudio/minimax-m2.1-gs32");
 
-  const aliases = { ...(cfg.agent?.modelAliases ?? {}) };
+  const aliases = { ...cfg.agent?.modelAliases };
   if (!aliases.Opus) aliases.Opus = "anthropic/claude-opus-4-5";
   if (!aliases.Minimax) aliases.Minimax = "lmstudio/minimax-m2.1-gs32";
 
-  const providers = { ...(cfg.models?.providers ?? {}) };
+  const providers = { ...cfg.models?.providers };
   if (!providers.lmstudio) {
     providers.lmstudio = {
       baseUrl: "http://127.0.0.1:1234/v1",
diff --git a/src/commands/onboard-skills.ts b/src/commands/onboard-skills.ts
index 38a1a06f6..bb14ac731 100644
--- a/src/commands/onboard-skills.ts
+++ b/src/commands/onboard-skills.ts
@@ -18,7 +18,7 @@ function upsertSkillEntry(
   skillKey: string,
   patch: { apiKey?: string },
 ): ClawdisConfig {
-  const entries = { ...(cfg.skills?.entries ?? {}) };
+  const entries = { ...cfg.skills?.entries };
   const existing = (entries[skillKey] as { apiKey?: string } | undefined) ?? {};
   entries[skillKey] = { ...existing, ...patch };
   return {
diff --git a/src/signal/monitor.ts b/src/signal/monitor.ts
index a307f22eb..a0e9afc66 100644
--- a/src/signal/monitor.ts
+++ b/src/signal/monitor.ts
@@ -19,7 +19,7 @@ type SignalEnvelope = {
   timestamp?: number | null;
   dataMessage?: SignalDataMessage | null;
   editMessage?: { dataMessage?: SignalDataMessage | null } | null;
-  syncMessage?: unknown | null;
+  syncMessage?: unknown;
 };
 
 type SignalDataMessage = {