From 806e3c12dce00dd778f6a7af42e5d716a0016bd7 Mon Sep 17 00:00:00 2001
From: Peter Steinberger <steipete@gmail.com>
Date: Fri, 13 Mar 2026 20:13:09 +0000
Subject: [PATCH] refactor: share doctor state migration helpers

---
 src/commands/doctor-state-migrations.test.ts | 31 ++++++++------------
 1 file changed, 13 insertions(+), 18 deletions(-)

diff --git a/src/commands/doctor-state-migrations.test.ts b/src/commands/doctor-state-migrations.test.ts
index d6541c745..ec465632c 100644
--- a/src/commands/doctor-state-migrations.test.ts
+++ b/src/commands/doctor-state-migrations.test.ts
@@ -41,6 +41,17 @@ function writeLegacyTelegramAllowFromStore(oauthDir: string) {
   );
 }
 
+async function runTelegramAllowFromMigration(params: { root: string; cfg: OpenClawConfig }) {
+  const oauthDir = ensureCredentialsDir(params.root);
+  writeLegacyTelegramAllowFromStore(oauthDir);
+  const detected = await detectLegacyStateMigrations({
+    cfg: params.cfg,
+    env: { OPENCLAW_STATE_DIR: params.root } as NodeJS.ProcessEnv,
+  });
+  const result = await runLegacyStateMigrations({ detected, now: () => 123 });
+  return { oauthDir, detected, result };
+}
+
 afterEach(async () => {
   resetAutoMigrateLegacyStateForTest();
   resetAutoMigrateLegacyStateDirForTest();
@@ -292,19 +303,11 @@ describe("doctor legacy state migrations", () => {
 
   it("migrates legacy Telegram pairing allowFrom store to account-scoped default file", async () => {
     const { root, cfg } = await makeRootWithEmptyCfg();
-    const oauthDir = ensureCredentialsDir(root);
-    writeLegacyTelegramAllowFromStore(oauthDir);
-
-    const detected = await detectLegacyStateMigrations({
-      cfg,
-      env: { OPENCLAW_STATE_DIR: root } as NodeJS.ProcessEnv,
-    });
+    const { oauthDir, detected, result } = await runTelegramAllowFromMigration({ root, cfg });
     expect(detected.pairingAllowFrom.hasLegacyTelegram).toBe(true);
     expect(
       detected.pairingAllowFrom.copyPlans.map((plan) => path.basename(plan.targetPath)),
     ).toEqual(["telegram-default-allowFrom.json"]);
-
-    const result = await runLegacyStateMigrations({ detected, now: () => 123 });
     expect(result.warnings).toEqual([]);
 
     const target = path.join(oauthDir, "telegram-default-allowFrom.json");
@@ -327,19 +330,11 @@ describe("doctor legacy state migrations", () => {
         },
       },
     };
-    const oauthDir = ensureCredentialsDir(root);
-    writeLegacyTelegramAllowFromStore(oauthDir);
-
-    const detected = await detectLegacyStateMigrations({
-      cfg,
-      env: { OPENCLAW_STATE_DIR: root } as NodeJS.ProcessEnv,
-    });
+    const { oauthDir, detected, result } = await runTelegramAllowFromMigration({ root, cfg });
     expect(detected.pairingAllowFrom.hasLegacyTelegram).toBe(true);
     expect(
       detected.pairingAllowFrom.copyPlans.map((plan) => path.basename(plan.targetPath)).toSorted(),
     ).toEqual(["telegram-bot1-allowFrom.json", "telegram-bot2-allowFrom.json"]);
-
-    const result = await runLegacyStateMigrations({ detected, now: () => 123 });
     expect(result.warnings).toEqual([]);
 
     const bot1Target = path.join(oauthDir, "telegram-bot1-allowFrom.json");