From 9ead79937edea39dd956872a024597129d197e21 Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sat, 21 Feb 2026 18:57:33 +0000 Subject: [PATCH] refactor(test): dedupe temp session path setup in file repair e2e --- src/agents/session-file-repair.e2e.test.ts | 25 +++++++++++++++------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/agents/session-file-repair.e2e.test.ts b/src/agents/session-file-repair.e2e.test.ts index 394222e3a..a4ba5d398 100644 --- a/src/agents/session-file-repair.e2e.test.ts +++ b/src/agents/session-file-repair.e2e.test.ts @@ -1,7 +1,7 @@ import fs from "node:fs/promises"; import os from "node:os"; import path from "node:path"; -import { describe, expect, it, vi } from "vitest"; +import { afterEach, describe, expect, it, vi } from "vitest"; import { repairSessionFileIfNeeded } from "./session-file-repair.js"; function buildSessionHeaderAndMessage() { @@ -22,10 +22,21 @@ function buildSessionHeaderAndMessage() { return { header, message }; } +const tempDirs: string[] = []; + +async function createTempSessionPath() { + const dir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-session-repair-")); + tempDirs.push(dir); + return { dir, file: path.join(dir, "session.jsonl") }; +} + +afterEach(async () => { + await Promise.all(tempDirs.splice(0).map((dir) => fs.rm(dir, { recursive: true, force: true }))); +}); + describe("repairSessionFileIfNeeded", () => { it("rewrites session files that contain malformed lines", async () => { - const dir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-session-repair-")); - const file = path.join(dir, "session.jsonl"); + const { file } = await createTempSessionPath(); const { header, message } = buildSessionHeaderAndMessage(); const content = `${JSON.stringify(header)}\n${JSON.stringify(message)}\n{"type":"message"`; @@ -46,8 +57,7 @@ describe("repairSessionFileIfNeeded", () => { }); it("does not drop CRLF-terminated JSONL lines", async () => { - const dir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-session-repair-")); - const file = path.join(dir, "session.jsonl"); + const { file } = await createTempSessionPath(); const { header, message } = buildSessionHeaderAndMessage(); const content = `${JSON.stringify(header)}\r\n${JSON.stringify(message)}\r\n`; await fs.writeFile(file, content, "utf-8"); @@ -58,8 +68,7 @@ describe("repairSessionFileIfNeeded", () => { }); it("warns and skips repair when the session header is invalid", async () => { - const dir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-session-repair-")); - const file = path.join(dir, "session.jsonl"); + const { file } = await createTempSessionPath(); const badHeader = { type: "message", id: "msg-1", @@ -79,7 +88,7 @@ describe("repairSessionFileIfNeeded", () => { }); it("returns a detailed reason when read errors are not ENOENT", async () => { - const dir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-session-repair-")); + const { dir } = await createTempSessionPath(); const warn = vi.fn(); const result = await repairSessionFileIfNeeded({ sessionFile: dir, warn });