refactor: dedupe cli config cron and install flows

src/shared/pid-alive.test.ts

@@ -2,6 +2,35 @@ import fsSync from "node:fs";
 import { describe, expect, it, vi } from "vitest";
 import { getProcessStartTime, isPidAlive } from "./pid-alive.js";
 
+function mockProcReads(entries: Record<string, string>) {
+  const originalReadFileSync = fsSync.readFileSync;
+  vi.spyOn(fsSync, "readFileSync").mockImplementation((filePath, encoding) => {
+    const key = String(filePath);
+    if (Object.hasOwn(entries, key)) {
+      return entries[key] as never;
+    }
+    return originalReadFileSync(filePath as never, encoding as never) as never;
+  });
+}
+
+async function withLinuxProcessPlatform<T>(run: () => Promise<T>): Promise<T> {
+  const originalPlatformDescriptor = Object.getOwnPropertyDescriptor(process, "platform");
+  if (!originalPlatformDescriptor) {
+    throw new Error("missing process.platform descriptor");
+  }
+  Object.defineProperty(process, "platform", {
+    ...originalPlatformDescriptor,
+    value: "linux",
+  });
+  try {
+    vi.resetModules();
+    return await run();
+  } finally {
+    Object.defineProperty(process, "platform", originalPlatformDescriptor);
+    vi.restoreAllMocks();
+  }
+}
+
 describe("isPidAlive", () => {
   it("returns true for the current running process", () => {
     expect(isPidAlive(process.pid)).toBe(true);
@@ -22,68 +51,29 @@ describe("isPidAlive", () => {
   it("returns false for zombie processes on Linux", async () => {
     const zombiePid = process.pid;
 
-    // Mock readFileSync to return zombie state for /proc/<pid>/status
-    const originalReadFileSync = fsSync.readFileSync;
-    vi.spyOn(fsSync, "readFileSync").mockImplementation((filePath, encoding) => {
-      if (filePath === `/proc/${zombiePid}/status`) {
-        return `Name:\tnode\nUmask:\t0022\nState:\tZ (zombie)\nTgid:\t${zombiePid}\nPid:\t${zombiePid}\n`;
-      }
-      return originalReadFileSync(filePath as never, encoding as never) as never;
+    mockProcReads({
+      [`/proc/${zombiePid}/status`]: `Name:\tnode\nUmask:\t0022\nState:\tZ (zombie)\nTgid:\t${zombiePid}\nPid:\t${zombiePid}\n`,
     });
-
-    // Override platform to linux so the zombie check runs
-    const originalPlatformDescriptor = Object.getOwnPropertyDescriptor(process, "platform");
-    if (!originalPlatformDescriptor) {
-      throw new Error("missing process.platform descriptor");
-    }
-    Object.defineProperty(process, "platform", {
-      ...originalPlatformDescriptor,
-      value: "linux",
-    });
-
-    try {
-      // Re-import the module so it picks up the mocked platform and fs
-      vi.resetModules();
+    await withLinuxProcessPlatform(async () => {
       const { isPidAlive: freshIsPidAlive } = await import("./pid-alive.js");
       expect(freshIsPidAlive(zombiePid)).toBe(false);
-    } finally {
-      Object.defineProperty(process, "platform", originalPlatformDescriptor);
-      vi.restoreAllMocks();
-    }
+    });
   });
 });
 
 describe("getProcessStartTime", () => {
   it("returns a number on Linux for the current process", async () => {
-    const originalPlatformDescriptor = Object.getOwnPropertyDescriptor(process, "platform");
-    if (!originalPlatformDescriptor) {
-      throw new Error("missing process.platform descriptor");
-    }
-
-    const originalReadFileSync = fsSync.readFileSync;
     // Simulate a realistic /proc/<pid>/stat line
     const fakeStat = `${process.pid} (node) S 1 ${process.pid} ${process.pid} 0 -1 4194304 12345 0 0 0 100 50 0 0 20 0 8 0 98765 123456789 5000 18446744073709551615 0 0 0 0 0 0 0 0 0 0 0 0 17 0 0 0 0 0 0`;
-    vi.spyOn(fsSync, "readFileSync").mockImplementation((filePath, encoding) => {
-      if (filePath === `/proc/${process.pid}/stat`) {
-        return fakeStat;
-      }
-      return originalReadFileSync(filePath as never, encoding as never) as never;
+    mockProcReads({
+      [`/proc/${process.pid}/stat`]: fakeStat,
     });
 
-    Object.defineProperty(process, "platform", {
-      ...originalPlatformDescriptor,
-      value: "linux",
-    });
-
-    try {
-      vi.resetModules();
+    await withLinuxProcessPlatform(async () => {
       const { getProcessStartTime: fresh } = await import("./pid-alive.js");
       const starttime = fresh(process.pid);
       expect(starttime).toBe(98765);
-    } finally {
-      Object.defineProperty(process, "platform", originalPlatformDescriptor);
-      vi.restoreAllMocks();
-    }
+    });
   });
 
   it("returns null on non-Linux platforms", () => {
@@ -104,62 +94,24 @@ describe("getProcessStartTime", () => {
   });
 
   it("returns null for malformed /proc stat content", async () => {
-    const originalPlatformDescriptor = Object.getOwnPropertyDescriptor(process, "platform");
-    if (!originalPlatformDescriptor) {
-      throw new Error("missing process.platform descriptor");
-    }
-
-    const originalReadFileSync = fsSync.readFileSync;
-    vi.spyOn(fsSync, "readFileSync").mockImplementation((filePath, encoding) => {
-      if (filePath === "/proc/42/stat") {
-        return "42 node S malformed";
-      }
-      return originalReadFileSync(filePath as never, encoding as never) as never;
+    mockProcReads({
+      "/proc/42/stat": "42 node S malformed",
     });
-
-    Object.defineProperty(process, "platform", {
-      ...originalPlatformDescriptor,
-      value: "linux",
-    });
-
-    try {
-      vi.resetModules();
+    await withLinuxProcessPlatform(async () => {
       const { getProcessStartTime: fresh } = await import("./pid-alive.js");
       expect(fresh(42)).toBeNull();
-    } finally {
-      Object.defineProperty(process, "platform", originalPlatformDescriptor);
-      vi.restoreAllMocks();
-    }
+    });
   });
 
   it("handles comm fields containing spaces and parentheses", async () => {
-    const originalPlatformDescriptor = Object.getOwnPropertyDescriptor(process, "platform");
-    if (!originalPlatformDescriptor) {
-      throw new Error("missing process.platform descriptor");
-    }
-
-    const originalReadFileSync = fsSync.readFileSync;
     // comm field with spaces and nested parens: "(My App (v2))"
     const fakeStat = `42 (My App (v2)) S 1 42 42 0 -1 4194304 0 0 0 0 0 0 0 0 20 0 1 0 55555 0 0 0 0 0 0 0 0 0 0 0 0 0 17 0 0 0 0 0 0`;
-    vi.spyOn(fsSync, "readFileSync").mockImplementation((filePath, encoding) => {
-      if (filePath === "/proc/42/stat") {
-        return fakeStat;
-      }
-      return originalReadFileSync(filePath as never, encoding as never) as never;
+    mockProcReads({
+      "/proc/42/stat": fakeStat,
     });
-
-    Object.defineProperty(process, "platform", {
-      ...originalPlatformDescriptor,
-      value: "linux",
-    });
-
-    try {
-      vi.resetModules();
+    await withLinuxProcessPlatform(async () => {
       const { getProcessStartTime: fresh } = await import("./pid-alive.js");
       expect(fresh(42)).toBe(55555);
-    } finally {
-      Object.defineProperty(process, "platform", originalPlatformDescriptor);
-      vi.restoreAllMocks();
-    }
+    });
   });
 });