chore: updated PR review skills and workflow info on tests + fake timers
This commit is contained in:
@@ -88,6 +88,7 @@ Is the code properly scoped?
|
|||||||
Is the code properly typed?
|
Is the code properly typed?
|
||||||
Is the code hardened?
|
Is the code hardened?
|
||||||
Do we have enough tests?
|
Do we have enough tests?
|
||||||
|
Are tests using fake timers where relevant? (e.g., debounce/throttle, retry backoff, timeout branches, delayed callbacks, polling loops)
|
||||||
Do not add performative tests, ensure tests are real and there are no regressions.
|
Do not add performative tests, ensure tests are real and there are no regressions.
|
||||||
Take your time, fix it properly, refactor if necessary.
|
Take your time, fix it properly, refactor if necessary.
|
||||||
Do you see any follow-up refactors we should do?
|
Do you see any follow-up refactors we should do?
|
||||||
|
|||||||
@@ -49,7 +49,7 @@ Create a checklist of all merge steps, print it, then continue and execute the c
|
|||||||
Use an isolated worktree for all merge work.
|
Use an isolated worktree for all merge work.
|
||||||
|
|
||||||
```sh
|
```sh
|
||||||
cd ~/Development/openclaw
|
cd ~/dev/openclaw
|
||||||
# Sanity: confirm you are in the repo
|
# Sanity: confirm you are in the repo
|
||||||
git rev-parse --show-toplevel
|
git rev-parse --show-toplevel
|
||||||
|
|
||||||
@@ -167,7 +167,7 @@ gh pr view <PR> --json state --jq .state
|
|||||||
Run cleanup only if step 6 returned `MERGED`.
|
Run cleanup only if step 6 returned `MERGED`.
|
||||||
|
|
||||||
```sh
|
```sh
|
||||||
cd ~/Development/openclaw
|
cd ~/dev/openclaw
|
||||||
|
|
||||||
git worktree remove ".worktrees/pr-<PR>" --force
|
git worktree remove ".worktrees/pr-<PR>" --force
|
||||||
|
|
||||||
|
|||||||
@@ -51,7 +51,7 @@ Create a checklist of all review steps, print it, then continue and execute the
|
|||||||
Use an isolated worktree for all review work.
|
Use an isolated worktree for all review work.
|
||||||
|
|
||||||
```sh
|
```sh
|
||||||
cd ~/Development/openclaw
|
cd ~/dev/openclaw
|
||||||
# Sanity: confirm you are in the repo
|
# Sanity: confirm you are in the repo
|
||||||
git rev-parse --show-toplevel
|
git rev-parse --show-toplevel
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user