diff --git a/apps/ios/Sources/Camera/CameraController.swift b/apps/ios/Sources/Camera/CameraController.swift index 1e9c10bc4..af12acecf 100644 --- a/apps/ios/Sources/Camera/CameraController.swift +++ b/apps/ios/Sources/Camera/CameraController.swift @@ -52,46 +52,27 @@ actor CameraController { try await self.ensureAccess(for: .video) - let session = AVCaptureSession() - session.sessionPreset = .photo - - guard let device = Self.pickCamera(facing: facing, deviceId: params.deviceId) else { - throw CameraError.cameraUnavailable - } - - let input = try AVCaptureDeviceInput(device: device) - guard session.canAddInput(input) else { - throw CameraError.captureFailed("Failed to add camera input") - } - session.addInput(input) - - let output = AVCapturePhotoOutput() - guard session.canAddOutput(output) else { - throw CameraError.captureFailed("Failed to add photo output") - } - session.addOutput(output) - output.maxPhotoQualityPrioritization = .quality + let prepared = try CameraCapturePipelineSupport.preparePhotoSession( + preferFrontCamera: facing == .front, + deviceId: params.deviceId, + pickCamera: { preferFrontCamera, deviceId in + Self.pickCamera(facing: preferFrontCamera ? .front : .back, deviceId: deviceId) + }, + cameraUnavailableError: CameraError.cameraUnavailable, + mapSetupError: { setupError in + CameraError.captureFailed(setupError.localizedDescription) + }) + let session = prepared.session + let output = prepared.output session.startRunning() defer { session.stopRunning() } - await Self.warmUpCaptureSession() + await CameraCapturePipelineSupport.warmUpCaptureSession() await Self.sleepDelayMs(delayMs) - let settings: AVCapturePhotoSettings = { - if output.availablePhotoCodecTypes.contains(.jpeg) { - return AVCapturePhotoSettings(format: [AVVideoCodecKey: AVVideoCodecType.jpeg]) - } - return AVCapturePhotoSettings() - }() - settings.photoQualityPrioritization = .quality - - var delegate: PhotoCaptureDelegate? - let rawData: Data = try await withCheckedThrowingContinuation { cont in - let d = PhotoCaptureDelegate(cont) - delegate = d - output.capturePhoto(with: settings, delegate: d) + let rawData = try await CameraCapturePipelineSupport.capturePhotoData(output: output) { continuation in + PhotoCaptureDelegate(continuation) } - withExtendedLifetime(delegate) {} let res = try PhotoCapture.transcodeJPEGForGateway( rawData: rawData, @@ -121,63 +102,36 @@ actor CameraController { try await self.ensureAccess(for: .audio) } - let session = AVCaptureSession() - session.sessionPreset = .high - - guard let camera = Self.pickCamera(facing: facing, deviceId: params.deviceId) else { - throw CameraError.cameraUnavailable - } - let cameraInput = try AVCaptureDeviceInput(device: camera) - guard session.canAddInput(cameraInput) else { - throw CameraError.captureFailed("Failed to add camera input") - } - session.addInput(cameraInput) - - if includeAudio { - guard let mic = AVCaptureDevice.default(for: .audio) else { - throw CameraError.microphoneUnavailable - } - let micInput = try AVCaptureDeviceInput(device: mic) - if session.canAddInput(micInput) { - session.addInput(micInput) - } else { - throw CameraError.captureFailed("Failed to add microphone input") - } - } - - let output = AVCaptureMovieFileOutput() - guard session.canAddOutput(output) else { - throw CameraError.captureFailed("Failed to add movie output") - } - session.addOutput(output) - output.maxRecordedDuration = CMTime(value: Int64(durationMs), timescale: 1000) - - session.startRunning() - defer { session.stopRunning() } - await Self.warmUpCaptureSession() - let movURL = FileManager().temporaryDirectory .appendingPathComponent("openclaw-camera-\(UUID().uuidString).mov") let mp4URL = FileManager().temporaryDirectory .appendingPathComponent("openclaw-camera-\(UUID().uuidString).mp4") - defer { try? FileManager().removeItem(at: movURL) try? FileManager().removeItem(at: mp4URL) } - var delegate: MovieFileDelegate? - let recordedURL: URL = try await withCheckedThrowingContinuation { cont in - let d = MovieFileDelegate(cont) - delegate = d - output.startRecording(to: movURL, recordingDelegate: d) - } - withExtendedLifetime(delegate) {} - - // Transcode .mov -> .mp4 for easier downstream handling. - try await Self.exportToMP4(inputURL: recordedURL, outputURL: mp4URL) - - let data = try Data(contentsOf: mp4URL) + let data = try await CameraCapturePipelineSupport.withWarmMovieSession( + preferFrontCamera: facing == .front, + deviceId: params.deviceId, + includeAudio: includeAudio, + durationMs: durationMs, + pickCamera: { preferFrontCamera, deviceId in + Self.pickCamera(facing: preferFrontCamera ? .front : .back, deviceId: deviceId) + }, + cameraUnavailableError: CameraError.cameraUnavailable, + mapSetupError: Self.mapMovieSetupError) { output in + var delegate: MovieFileDelegate? + let recordedURL: URL = try await withCheckedThrowingContinuation { cont in + let d = MovieFileDelegate(cont) + delegate = d + output.startRecording(to: movURL, recordingDelegate: d) + } + withExtendedLifetime(delegate) {} + // Transcode .mov -> .mp4 for easier downstream handling. + try await Self.exportToMP4(inputURL: recordedURL, outputURL: mp4URL) + return try Data(contentsOf: mp4URL) + } return ( format: format.rawValue, base64: data.base64EncodedString(), @@ -196,22 +150,7 @@ actor CameraController { } private func ensureAccess(for mediaType: AVMediaType) async throws { - let status = AVCaptureDevice.authorizationStatus(for: mediaType) - switch status { - case .authorized: - return - case .notDetermined: - let ok = await withCheckedContinuation(isolation: nil) { cont in - AVCaptureDevice.requestAccess(for: mediaType) { granted in - cont.resume(returning: granted) - } - } - if !ok { - throw CameraError.permissionDenied(kind: mediaType == .video ? "Camera" : "Microphone") - } - case .denied, .restricted: - throw CameraError.permissionDenied(kind: mediaType == .video ? "Camera" : "Microphone") - @unknown default: + if !(await CameraAuthorization.isAuthorized(for: mediaType)) { throw CameraError.permissionDenied(kind: mediaType == .video ? "Camera" : "Microphone") } } @@ -233,12 +172,15 @@ actor CameraController { return AVCaptureDevice.default(for: .video) } + private nonisolated static func mapMovieSetupError(_ setupError: CameraSessionConfigurationError) -> CameraError { + CameraCapturePipelineSupport.mapMovieSetupError( + setupError, + microphoneUnavailableError: .microphoneUnavailable, + captureFailed: { .captureFailed($0) }) + } + private nonisolated static func positionLabel(_ position: AVCaptureDevice.Position) -> String { - switch position { - case .front: "front" - case .back: "back" - default: "unspecified" - } + CameraCapturePipelineSupport.positionLabel(position) } private nonisolated static func discoverVideoDevices() -> [AVCaptureDevice] { @@ -307,11 +249,6 @@ actor CameraController { } } - private nonisolated static func warmUpCaptureSession() async { - // A short delay after `startRunning()` significantly reduces "blank first frame" captures on some devices. - try? await Task.sleep(nanoseconds: 150_000_000) // 150ms - } - private nonisolated static func sleepDelayMs(_ delayMs: Int) async { guard delayMs > 0 else { return } let maxDelayMs = 10 * 1000 diff --git a/apps/ios/Sources/Contacts/ContactsService.swift b/apps/ios/Sources/Contacts/ContactsService.swift index db203d070..efe89f8a2 100644 --- a/apps/ios/Sources/Contacts/ContactsService.swift +++ b/apps/ios/Sources/Contacts/ContactsService.swift @@ -15,14 +15,7 @@ final class ContactsService: ContactsServicing { } func search(params: OpenClawContactsSearchParams) async throws -> OpenClawContactsSearchPayload { - let store = CNContactStore() - let status = CNContactStore.authorizationStatus(for: .contacts) - let authorized = await Self.ensureAuthorization(store: store, status: status) - guard authorized else { - throw NSError(domain: "Contacts", code: 1, userInfo: [ - NSLocalizedDescriptionKey: "CONTACTS_PERMISSION_REQUIRED: grant Contacts permission", - ]) - } + let store = try await Self.authorizedStore() let limit = max(1, min(params.limit ?? 25, 200)) @@ -47,14 +40,7 @@ final class ContactsService: ContactsServicing { } func add(params: OpenClawContactsAddParams) async throws -> OpenClawContactsAddPayload { - let store = CNContactStore() - let status = CNContactStore.authorizationStatus(for: .contacts) - let authorized = await Self.ensureAuthorization(store: store, status: status) - guard authorized else { - throw NSError(domain: "Contacts", code: 1, userInfo: [ - NSLocalizedDescriptionKey: "CONTACTS_PERMISSION_REQUIRED: grant Contacts permission", - ]) - } + let store = try await Self.authorizedStore() let givenName = params.givenName?.trimmingCharacters(in: .whitespacesAndNewlines) let familyName = params.familyName?.trimmingCharacters(in: .whitespacesAndNewlines) @@ -127,6 +113,18 @@ final class ContactsService: ContactsServicing { } } + private static func authorizedStore() async throws -> CNContactStore { + let store = CNContactStore() + let status = CNContactStore.authorizationStatus(for: .contacts) + let authorized = await Self.ensureAuthorization(store: store, status: status) + guard authorized else { + throw NSError(domain: "Contacts", code: 1, userInfo: [ + NSLocalizedDescriptionKey: "CONTACTS_PERMISSION_REQUIRED: grant Contacts permission", + ]) + } + return store + } + private static func normalizeStrings(_ values: [String]?, lowercased: Bool = false) -> [String] { (values ?? []) .map { $0.trimmingCharacters(in: .whitespacesAndNewlines) } diff --git a/apps/ios/Sources/Gateway/GatewayDiscoveryModel.swift b/apps/ios/Sources/Gateway/GatewayDiscoveryModel.swift index 04bb220d5..1090904f0 100644 --- a/apps/ios/Sources/Gateway/GatewayDiscoveryModel.swift +++ b/apps/ios/Sources/Gateway/GatewayDiscoveryModel.swift @@ -53,23 +53,17 @@ final class GatewayDiscoveryModel { self.appendDebugLog("start()") for domain in OpenClawBonjour.gatewayServiceDomains { - let params = NWParameters.tcp - params.includePeerToPeer = true - let browser = NWBrowser( - for: .bonjour(type: OpenClawBonjour.gatewayServiceType, domain: domain), - using: params) - - browser.stateUpdateHandler = { [weak self] state in - Task { @MainActor in + let browser = GatewayDiscoveryBrowserSupport.makeBrowser( + serviceType: OpenClawBonjour.gatewayServiceType, + domain: domain, + queueLabelPrefix: "ai.openclaw.ios.gateway-discovery", + onState: { [weak self] state in guard let self else { return } self.statesByDomain[domain] = state self.updateStatusText() self.appendDebugLog("state[\(domain)]: \(Self.prettyState(state))") - } - } - - browser.browseResultsChangedHandler = { [weak self] results, _ in - Task { @MainActor in + }, + onResults: { [weak self] results in guard let self else { return } self.gatewaysByDomain[domain] = results.compactMap { result -> DiscoveredGateway? in switch result.endpoint { @@ -98,13 +92,10 @@ final class GatewayDiscoveryModel { } } .sorted { $0.name.localizedCaseInsensitiveCompare($1.name) == .orderedAscending } - self.recomputeGateways() - } - } + }) self.browsers[domain] = browser - browser.start(queue: DispatchQueue(label: "ai.openclaw.ios.gateway-discovery.\(domain)")) } } diff --git a/apps/ios/Sources/Gateway/GatewayServiceResolver.swift b/apps/ios/Sources/Gateway/GatewayServiceResolver.swift index 882a4e7d0..dab3b4787 100644 --- a/apps/ios/Sources/Gateway/GatewayServiceResolver.swift +++ b/apps/ios/Sources/Gateway/GatewayServiceResolver.swift @@ -1,4 +1,5 @@ import Foundation +import OpenClawKit // NetService-based resolver for Bonjour services. // Used to resolve the service endpoint (SRV + A/AAAA) without trusting TXT for routing. @@ -20,8 +21,7 @@ final class GatewayServiceResolver: NSObject, NetServiceDelegate { } func start(timeout: TimeInterval = 2.0) { - self.service.schedule(in: .main, forMode: .common) - self.service.resolve(withTimeout: timeout) + BonjourServiceResolverSupport.start(self.service, timeout: timeout) } func netServiceDidResolveAddress(_ sender: NetService) { @@ -47,9 +47,6 @@ final class GatewayServiceResolver: NSObject, NetServiceDelegate { } private static func normalizeHost(_ raw: String?) -> String? { - let trimmed = raw?.trimmingCharacters(in: .whitespacesAndNewlines) ?? "" - if trimmed.isEmpty { return nil } - return trimmed.hasSuffix(".") ? String(trimmed.dropLast()) : trimmed + BonjourServiceResolverSupport.normalizeHost(raw) } } - diff --git a/apps/ios/Sources/Location/LocationService.swift b/apps/ios/Sources/Location/LocationService.swift index f1f0f69ed..f94ca15f3 100644 --- a/apps/ios/Sources/Location/LocationService.swift +++ b/apps/ios/Sources/Location/LocationService.swift @@ -3,7 +3,7 @@ import CoreLocation import Foundation @MainActor -final class LocationService: NSObject, CLLocationManagerDelegate { +final class LocationService: NSObject, CLLocationManagerDelegate, LocationServiceCommon { enum Error: Swift.Error { case timeout case unavailable @@ -17,21 +17,18 @@ final class LocationService: NSObject, CLLocationManagerDelegate { private var significantLocationCallback: (@Sendable (CLLocation) -> Void)? private var isMonitoringSignificantChanges = false + var locationManager: CLLocationManager { + self.manager + } + + var locationRequestContinuation: CheckedContinuation? { + get { self.locationContinuation } + set { self.locationContinuation = newValue } + } + override init() { super.init() - self.manager.delegate = self - self.manager.desiredAccuracy = kCLLocationAccuracyBest - } - - func authorizationStatus() -> CLAuthorizationStatus { - self.manager.authorizationStatus - } - - func accuracyAuthorization() -> CLAccuracyAuthorization { - if #available(iOS 14.0, *) { - return self.manager.accuracyAuthorization - } - return .fullAccuracy + self.configureLocationManager() } func ensureAuthorization(mode: OpenClawLocationMode) async -> CLAuthorizationStatus { @@ -62,25 +59,14 @@ final class LocationService: NSObject, CLLocationManagerDelegate { maxAgeMs: Int?, timeoutMs: Int?) async throws -> CLLocation { - let now = Date() - if let maxAgeMs, - let cached = self.manager.location, - now.timeIntervalSince(cached.timestamp) * 1000 <= Double(maxAgeMs) - { - return cached - } - - self.manager.desiredAccuracy = Self.accuracyValue(desiredAccuracy) - let timeout = max(0, timeoutMs ?? 10000) - return try await self.withTimeout(timeoutMs: timeout) { - try await self.requestLocation() - } - } - - private func requestLocation() async throws -> CLLocation { - try await withCheckedThrowingContinuation { cont in - self.locationContinuation = cont - self.manager.requestLocation() + _ = params + return try await LocationCurrentRequest.resolve( + manager: self.manager, + desiredAccuracy: desiredAccuracy, + maxAgeMs: maxAgeMs, + timeoutMs: timeoutMs, + request: { try await self.requestLocationOnce() }) { timeoutMs, operation in + try await self.withTimeout(timeoutMs: timeoutMs, operation: operation) } } @@ -97,24 +83,13 @@ final class LocationService: NSObject, CLLocationManagerDelegate { try await AsyncTimeout.withTimeoutMs(timeoutMs: timeoutMs, onTimeout: { Error.timeout }, operation: operation) } - private static func accuracyValue(_ accuracy: OpenClawLocationAccuracy) -> CLLocationAccuracy { - switch accuracy { - case .coarse: - kCLLocationAccuracyKilometer - case .balanced: - kCLLocationAccuracyHundredMeters - case .precise: - kCLLocationAccuracyBest - } - } - func startLocationUpdates( desiredAccuracy: OpenClawLocationAccuracy, significantChangesOnly: Bool) -> AsyncStream { self.stopLocationUpdates() - self.manager.desiredAccuracy = Self.accuracyValue(desiredAccuracy) + self.manager.desiredAccuracy = LocationCurrentRequest.accuracyValue(desiredAccuracy) self.manager.pausesLocationUpdatesAutomatically = true self.manager.allowsBackgroundLocationUpdates = true diff --git a/apps/ios/Sources/Model/NodeAppModel+Canvas.swift b/apps/ios/Sources/Model/NodeAppModel+Canvas.swift index e8dce2cd3..922757a65 100644 --- a/apps/ios/Sources/Model/NodeAppModel+Canvas.swift +++ b/apps/ios/Sources/Model/NodeAppModel+Canvas.swift @@ -1,5 +1,6 @@ import Foundation import Network +import OpenClawKit import os extension NodeAppModel { @@ -11,24 +12,12 @@ extension NodeAppModel { guard let raw = await self.gatewaySession.currentCanvasHostUrl() else { return nil } let trimmed = raw.trimmingCharacters(in: .whitespacesAndNewlines) guard !trimmed.isEmpty, let base = URL(string: trimmed) else { return nil } - if let host = base.host, Self.isLoopbackHost(host) { + if let host = base.host, LoopbackHost.isLoopback(host) { return nil } return base.appendingPathComponent("__openclaw__/a2ui/").absoluteString + "?platform=ios" } - private static func isLoopbackHost(_ host: String) -> Bool { - let normalized = host.trimmingCharacters(in: .whitespacesAndNewlines).lowercased() - if normalized.isEmpty { return true } - if normalized == "localhost" || normalized == "::1" || normalized == "0.0.0.0" { - return true - } - if normalized == "127.0.0.1" || normalized.hasPrefix("127.") { - return true - } - return false - } - func showA2UIOnConnectIfNeeded() async { guard let a2uiUrl = await self.resolveA2UIHostURL() else { await MainActor.run { diff --git a/apps/ios/Sources/Onboarding/GatewayOnboardingView.swift b/apps/ios/Sources/Onboarding/GatewayOnboardingView.swift index bf6c0ba2d..bb0dea241 100644 --- a/apps/ios/Sources/Onboarding/GatewayOnboardingView.swift +++ b/apps/ios/Sources/Onboarding/GatewayOnboardingView.swift @@ -41,15 +41,17 @@ private struct AutoDetectStep: View { .foregroundStyle(.secondary) } - Section("Connection status") { - ConnectionStatusBox( - statusLines: self.connectionStatusLines(), - secondaryLine: self.connectStatusText) - } + gatewayConnectionStatusSection( + appModel: self.appModel, + gatewayController: self.gatewayController, + secondaryLine: self.connectStatusText) Section { Button("Retry") { - self.resetConnectionState() + resetGatewayConnectionState( + appModel: self.appModel, + connectStatusText: &self.connectStatusText, + connectingGatewayID: &self.connectingGatewayID) self.triggerAutoConnect() } .disabled(self.connectingGatewayID != nil) @@ -94,15 +96,6 @@ private struct AutoDetectStep: View { return nil } - private func connectionStatusLines() -> [String] { - ConnectionStatusBox.defaultLines(appModel: self.appModel, gatewayController: self.gatewayController) - } - - private func resetConnectionState() { - self.appModel.disconnectGateway() - self.connectStatusText = nil - self.connectingGatewayID = nil - } } private struct ManualEntryStep: View { @@ -162,11 +155,10 @@ private struct ManualEntryStep: View { .autocorrectionDisabled() } - Section("Connection status") { - ConnectionStatusBox( - statusLines: self.connectionStatusLines(), - secondaryLine: self.connectStatusText) - } + gatewayConnectionStatusSection( + appModel: self.appModel, + gatewayController: self.gatewayController, + secondaryLine: self.connectStatusText) Section { Button { @@ -185,7 +177,10 @@ private struct ManualEntryStep: View { .disabled(self.connectingGatewayID != nil) Button("Retry") { - self.resetConnectionState() + resetGatewayConnectionState( + appModel: self.appModel, + connectStatusText: &self.connectStatusText, + connectingGatewayID: &self.connectingGatewayID) self.resetManualForm() } .disabled(self.connectingGatewayID != nil) @@ -237,16 +232,6 @@ private struct ManualEntryStep: View { return Int(trimmed.filter { $0.isNumber }) } - private func connectionStatusLines() -> [String] { - ConnectionStatusBox.defaultLines(appModel: self.appModel, gatewayController: self.gatewayController) - } - - private func resetConnectionState() { - self.appModel.disconnectGateway() - self.connectStatusText = nil - self.connectingGatewayID = nil - } - private func resetManualForm() { self.setupCode = "" self.setupStatusText = nil @@ -317,6 +302,38 @@ private struct ManualEntryStep: View { // (GatewaySetupCode) decode raw setup codes. } +private func gatewayConnectionStatusLines( + appModel: NodeAppModel, + gatewayController: GatewayConnectionController) -> [String] +{ + ConnectionStatusBox.defaultLines(appModel: appModel, gatewayController: gatewayController) +} + +private func resetGatewayConnectionState( + appModel: NodeAppModel, + connectStatusText: inout String?, + connectingGatewayID: inout String?) +{ + appModel.disconnectGateway() + connectStatusText = nil + connectingGatewayID = nil +} + +@ViewBuilder +private func gatewayConnectionStatusSection( + appModel: NodeAppModel, + gatewayController: GatewayConnectionController, + secondaryLine: String?) -> some View +{ + Section("Connection status") { + ConnectionStatusBox( + statusLines: gatewayConnectionStatusLines( + appModel: appModel, + gatewayController: gatewayController), + secondaryLine: secondaryLine) + } +} + private struct ConnectionStatusBox: View { let statusLines: [String] let secondaryLine: String? diff --git a/apps/ios/Sources/Onboarding/OnboardingWizardView.swift b/apps/ios/Sources/Onboarding/OnboardingWizardView.swift index b0dbdc136..8a97b20e0 100644 --- a/apps/ios/Sources/Onboarding/OnboardingWizardView.swift +++ b/apps/ios/Sources/Onboarding/OnboardingWizardView.swift @@ -489,21 +489,7 @@ struct OnboardingWizardView: View { TextField("Port", text: self.$manualPortText) .keyboardType(.numberPad) Toggle("Use TLS", isOn: self.$manualTLS) - - Button { - Task { await self.connectManual() } - } label: { - if self.connectingGatewayID == "manual" { - HStack(spacing: 8) { - ProgressView() - .progressViewStyle(.circular) - Text("Connecting…") - } - } else { - Text("Connect") - } - } - .disabled(!self.canConnectManual || self.connectingGatewayID != nil) + self.manualConnectButton } header: { Text("Developer Local") } footer: { @@ -631,24 +617,27 @@ struct OnboardingWizardView: View { TextField("Discovery Domain (optional)", text: self.$discoveryDomain) .textInputAutocapitalization(.never) .autocorrectionDisabled() - - Button { - Task { await self.connectManual() } - } label: { - if self.connectingGatewayID == "manual" { - HStack(spacing: 8) { - ProgressView() - .progressViewStyle(.circular) - Text("Connecting…") - } - } else { - Text("Connect") - } - } - .disabled(!self.canConnectManual || self.connectingGatewayID != nil) + self.manualConnectButton } } + private var manualConnectButton: some View { + Button { + Task { await self.connectManual() } + } label: { + if self.connectingGatewayID == "manual" { + HStack(spacing: 8) { + ProgressView() + .progressViewStyle(.circular) + Text("Connecting…") + } + } else { + Text("Connect") + } + } + .disabled(!self.canConnectManual || self.connectingGatewayID != nil) + } + private func handleScannedLink(_ link: GatewayConnectDeepLink) { self.manualHost = link.host self.manualPort = link.port diff --git a/apps/ios/Sources/OpenClawApp.swift b/apps/ios/Sources/OpenClawApp.swift index 27f7f5e02..c94b1209f 100644 --- a/apps/ios/Sources/OpenClawApp.swift +++ b/apps/ios/Sources/OpenClawApp.swift @@ -456,11 +456,7 @@ enum WatchPromptNotificationBridge { ) async throws { try await withCheckedThrowingContinuation { (continuation: CheckedContinuation) in center.add(request) { error in - if let error { - continuation.resume(throwing: error) - } else { - continuation.resume(returning: ()) - } + ThrowingContinuationSupport.resumeVoid(continuation, error: error) } } } diff --git a/apps/ios/Sources/RootCanvas.swift b/apps/ios/Sources/RootCanvas.swift index dd0f389ed..3fc62d7e8 100644 --- a/apps/ios/Sources/RootCanvas.swift +++ b/apps/ios/Sources/RootCanvas.swift @@ -177,20 +177,7 @@ struct RootCanvas: View { } private var gatewayStatus: StatusPill.GatewayState { - if self.appModel.gatewayServerName != nil { return .connected } - - let text = self.appModel.gatewayStatusText.trimmingCharacters(in: .whitespacesAndNewlines) - if text.localizedCaseInsensitiveContains("connecting") || - text.localizedCaseInsensitiveContains("reconnecting") - { - return .connecting - } - - if text.localizedCaseInsensitiveContains("error") { - return .error - } - - return .disconnected + GatewayStatusBuilder.build(appModel: self.appModel) } private func updateIdleTimer() { @@ -343,82 +330,18 @@ private struct CanvasContent: View { .transition(.move(edge: .top).combined(with: .opacity)) } } - .confirmationDialog( - "Gateway", + .gatewayActionsDialog( isPresented: self.$showGatewayActions, - titleVisibility: .visible) - { - Button("Disconnect", role: .destructive) { - self.appModel.disconnectGateway() - } - Button("Open Settings") { - self.openSettings() - } - Button("Cancel", role: .cancel) {} - } message: { - Text("Disconnect from the gateway?") - } + onDisconnect: { self.appModel.disconnectGateway() }, + onOpenSettings: { self.openSettings() }) } private var statusActivity: StatusPill.Activity? { - // Status pill owns transient activity state so it doesn't overlap the connection indicator. - if self.appModel.isBackgrounded { - return StatusPill.Activity( - title: "Foreground required", - systemImage: "exclamationmark.triangle.fill", - tint: .orange) - } - - let gatewayStatus = self.appModel.gatewayStatusText.trimmingCharacters(in: .whitespacesAndNewlines) - let gatewayLower = gatewayStatus.lowercased() - if gatewayLower.contains("repair") { - return StatusPill.Activity(title: "Repairing…", systemImage: "wrench.and.screwdriver", tint: .orange) - } - if gatewayLower.contains("approval") || gatewayLower.contains("pairing") { - return StatusPill.Activity(title: "Approval pending", systemImage: "person.crop.circle.badge.clock") - } - // Avoid duplicating the primary gateway status ("Connecting…") in the activity slot. - - if self.appModel.screenRecordActive { - return StatusPill.Activity(title: "Recording screen…", systemImage: "record.circle.fill", tint: .red) - } - - if let cameraHUDText, !cameraHUDText.isEmpty, let cameraHUDKind { - let systemImage: String - let tint: Color? - switch cameraHUDKind { - case .photo: - systemImage = "camera.fill" - tint = nil - case .recording: - systemImage = "video.fill" - tint = .red - case .success: - systemImage = "checkmark.circle.fill" - tint = .green - case .error: - systemImage = "exclamationmark.triangle.fill" - tint = .red - } - return StatusPill.Activity(title: cameraHUDText, systemImage: systemImage, tint: tint) - } - - if self.voiceWakeEnabled { - let voiceStatus = self.appModel.voiceWake.statusText - if voiceStatus.localizedCaseInsensitiveContains("microphone permission") { - return StatusPill.Activity(title: "Mic permission", systemImage: "mic.slash", tint: .orange) - } - if voiceStatus == "Paused" { - // Talk mode intentionally pauses voice wake to release the mic. Don't spam the HUD for that case. - if self.appModel.talkMode.isEnabled { - return nil - } - let suffix = self.appModel.isBackgrounded ? " (background)" : "" - return StatusPill.Activity(title: "Voice Wake paused\(suffix)", systemImage: "pause.circle.fill") - } - } - - return nil + StatusActivityBuilder.build( + appModel: self.appModel, + voiceWakeEnabled: self.voiceWakeEnabled, + cameraHUDText: self.cameraHUDText, + cameraHUDKind: self.cameraHUDKind) } } diff --git a/apps/ios/Sources/RootTabs.swift b/apps/ios/Sources/RootTabs.swift index 4733a4a30..fb5176725 100644 --- a/apps/ios/Sources/RootTabs.swift +++ b/apps/ios/Sources/RootTabs.swift @@ -70,38 +70,14 @@ struct RootTabs: View { self.toastDismissTask?.cancel() self.toastDismissTask = nil } - .confirmationDialog( - "Gateway", + .gatewayActionsDialog( isPresented: self.$showGatewayActions, - titleVisibility: .visible) - { - Button("Disconnect", role: .destructive) { - self.appModel.disconnectGateway() - } - Button("Open Settings") { - self.selectedTab = 2 - } - Button("Cancel", role: .cancel) {} - } message: { - Text("Disconnect from the gateway?") - } + onDisconnect: { self.appModel.disconnectGateway() }, + onOpenSettings: { self.selectedTab = 2 }) } private var gatewayStatus: StatusPill.GatewayState { - if self.appModel.gatewayServerName != nil { return .connected } - - let text = self.appModel.gatewayStatusText.trimmingCharacters(in: .whitespacesAndNewlines) - if text.localizedCaseInsensitiveContains("connecting") || - text.localizedCaseInsensitiveContains("reconnecting") - { - return .connecting - } - - if text.localizedCaseInsensitiveContains("error") { - return .error - } - - return .disconnected + GatewayStatusBuilder.build(appModel: self.appModel) } private var statusActivity: StatusPill.Activity? { diff --git a/apps/ios/Sources/Screen/ScreenController.swift b/apps/ios/Sources/Screen/ScreenController.swift index 004523236..5c9450335 100644 --- a/apps/ios/Sources/Screen/ScreenController.swift +++ b/apps/ios/Sources/Screen/ScreenController.swift @@ -35,7 +35,7 @@ final class ScreenController { if let url = URL(string: trimmed), !url.isFileURL, let host = url.host, - Self.isLoopbackHost(host) + LoopbackHost.isLoopback(host) { // Never try to load loopback URLs from a remote gateway. self.showDefaultCanvas() @@ -87,25 +87,11 @@ final class ScreenController { func applyDebugStatusIfNeeded() { guard let webView = self.activeWebView else { return } - let enabled = self.debugStatusEnabled - let title = self.debugStatusTitle - let subtitle = self.debugStatusSubtitle - let js = """ - (() => { - try { - const api = globalThis.__openclaw; - if (!api) return; - if (typeof api.setDebugStatusEnabled === 'function') { - api.setDebugStatusEnabled(\(enabled ? "true" : "false")); - } - if (!\(enabled ? "true" : "false")) return; - if (typeof api.setStatus === 'function') { - api.setStatus(\(Self.jsValue(title)), \(Self.jsValue(subtitle))); - } - } catch (_) {} - })() - """ - webView.evaluateJavaScript(js) { _, _ in } + WebViewJavaScriptSupport.applyDebugStatus( + webView: webView, + enabled: self.debugStatusEnabled, + title: self.debugStatusTitle, + subtitle: self.debugStatusSubtitle) } func waitForA2UIReady(timeoutMs: Int) async -> Bool { @@ -137,46 +123,11 @@ final class ScreenController { NSLocalizedDescriptionKey: "web view unavailable", ]) } - return try await withCheckedThrowingContinuation { cont in - webView.evaluateJavaScript(javaScript) { result, error in - if let error { - cont.resume(throwing: error) - return - } - if let result { - cont.resume(returning: String(describing: result)) - } else { - cont.resume(returning: "") - } - } - } + return try await WebViewJavaScriptSupport.evaluateToString(webView: webView, javaScript: javaScript) } func snapshotPNGBase64(maxWidth: CGFloat? = nil) async throws -> String { - let config = WKSnapshotConfiguration() - if let maxWidth { - config.snapshotWidth = NSNumber(value: Double(maxWidth)) - } - guard let webView = self.activeWebView else { - throw NSError(domain: "Screen", code: 3, userInfo: [ - NSLocalizedDescriptionKey: "web view unavailable", - ]) - } - let image: UIImage = try await withCheckedThrowingContinuation { cont in - webView.takeSnapshot(with: config) { image, error in - if let error { - cont.resume(throwing: error) - return - } - guard let image else { - cont.resume(throwing: NSError(domain: "Screen", code: 2, userInfo: [ - NSLocalizedDescriptionKey: "snapshot failed", - ])) - return - } - cont.resume(returning: image) - } - } + let image = try await self.snapshotImage(maxWidth: maxWidth) guard let data = image.pngData() else { throw NSError(domain: "Screen", code: 1, userInfo: [ NSLocalizedDescriptionKey: "snapshot encode failed", @@ -190,30 +141,7 @@ final class ScreenController { format: OpenClawCanvasSnapshotFormat, quality: Double? = nil) async throws -> String { - let config = WKSnapshotConfiguration() - if let maxWidth { - config.snapshotWidth = NSNumber(value: Double(maxWidth)) - } - guard let webView = self.activeWebView else { - throw NSError(domain: "Screen", code: 3, userInfo: [ - NSLocalizedDescriptionKey: "web view unavailable", - ]) - } - let image: UIImage = try await withCheckedThrowingContinuation { cont in - webView.takeSnapshot(with: config) { image, error in - if let error { - cont.resume(throwing: error) - return - } - guard let image else { - cont.resume(throwing: NSError(domain: "Screen", code: 2, userInfo: [ - NSLocalizedDescriptionKey: "snapshot failed", - ])) - return - } - cont.resume(returning: image) - } - } + let image = try await self.snapshotImage(maxWidth: maxWidth) let data: Data? switch format { @@ -231,6 +159,34 @@ final class ScreenController { return data.base64EncodedString() } + private func snapshotImage(maxWidth: CGFloat?) async throws -> UIImage { + let config = WKSnapshotConfiguration() + if let maxWidth { + config.snapshotWidth = NSNumber(value: Double(maxWidth)) + } + guard let webView = self.activeWebView else { + throw NSError(domain: "Screen", code: 3, userInfo: [ + NSLocalizedDescriptionKey: "web view unavailable", + ]) + } + let image: UIImage = try await withCheckedThrowingContinuation { cont in + webView.takeSnapshot(with: config) { image, error in + if let error { + cont.resume(throwing: error) + return + } + guard let image else { + cont.resume(throwing: NSError(domain: "Screen", code: 2, userInfo: [ + NSLocalizedDescriptionKey: "snapshot failed", + ])) + return + } + cont.resume(returning: image) + } + } + return image + } + func attachWebView(_ webView: WKWebView) { self.activeWebView = webView self.reload() @@ -258,17 +214,6 @@ final class ScreenController { ext: "html", subdirectory: "CanvasScaffold") - private static func isLoopbackHost(_ host: String) -> Bool { - let normalized = host.trimmingCharacters(in: .whitespacesAndNewlines).lowercased() - if normalized.isEmpty { return true } - if normalized == "localhost" || normalized == "::1" || normalized == "0.0.0.0" { - return true - } - if normalized == "127.0.0.1" || normalized.hasPrefix("127.") { - return true - } - return false - } func isTrustedCanvasUIURL(_ url: URL) -> Bool { guard url.isFileURL else { return false } let std = url.standardizedFileURL @@ -290,59 +235,8 @@ final class ScreenController { scrollView.bounces = allowScroll } - private static func jsValue(_ value: String?) -> String { - guard let value else { return "null" } - if let data = try? JSONSerialization.data(withJSONObject: [value]), - let encoded = String(data: data, encoding: .utf8), - encoded.count >= 2 - { - return String(encoded.dropFirst().dropLast()) - } - return "null" - } - func isLocalNetworkCanvasURL(_ url: URL) -> Bool { - guard let scheme = url.scheme?.lowercased(), scheme == "http" || scheme == "https" else { - return false - } - guard let host = url.host?.trimmingCharacters(in: .whitespacesAndNewlines), !host.isEmpty else { - return false - } - if host == "localhost" { return true } - if host.hasSuffix(".local") { return true } - if host.hasSuffix(".ts.net") { return true } - if host.hasSuffix(".tailscale.net") { return true } - // Allow MagicDNS / LAN hostnames like "peters-mac-studio-1". - if !host.contains("."), !host.contains(":") { return true } - if let ipv4 = Self.parseIPv4(host) { - return Self.isLocalNetworkIPv4(ipv4) - } - return false - } - - private static func parseIPv4(_ host: String) -> (UInt8, UInt8, UInt8, UInt8)? { - let parts = host.split(separator: ".", omittingEmptySubsequences: false) - guard parts.count == 4 else { return nil } - let bytes: [UInt8] = parts.compactMap { UInt8($0) } - guard bytes.count == 4 else { return nil } - return (bytes[0], bytes[1], bytes[2], bytes[3]) - } - - private static func isLocalNetworkIPv4(_ ip: (UInt8, UInt8, UInt8, UInt8)) -> Bool { - let (a, b, _, _) = ip - // 10.0.0.0/8 - if a == 10 { return true } - // 172.16.0.0/12 - if a == 172, (16...31).contains(Int(b)) { return true } - // 192.168.0.0/16 - if a == 192, b == 168 { return true } - // 127.0.0.0/8 - if a == 127 { return true } - // 169.254.0.0/16 (link-local) - if a == 169, b == 254 { return true } - // Tailscale: 100.64.0.0/10 - if a == 100, (64...127).contains(Int(b)) { return true } - return false + LocalNetworkURLSupport.isLocalNetworkHTTPURL(url) } nonisolated static func parseA2UIActionBody(_ body: Any) -> [String: Any]? { diff --git a/apps/ios/Sources/Screen/ScreenRecordService.swift b/apps/ios/Sources/Screen/ScreenRecordService.swift index c353d86f2..a987b2165 100644 --- a/apps/ios/Sources/Screen/ScreenRecordService.swift +++ b/apps/ios/Sources/Screen/ScreenRecordService.swift @@ -84,8 +84,8 @@ final class ScreenRecordService: @unchecked Sendable { throw ScreenRecordError.invalidScreenIndex(idx) } - let durationMs = Self.clampDurationMs(durationMs) - let fps = Self.clampFps(fps) + let durationMs = CaptureRateLimits.clampDurationMs(durationMs) + let fps = CaptureRateLimits.clampFps(fps, maxFps: 30) let fpsInt = Int32(fps.rounded()) let fpsValue = Double(fpsInt) let includeAudio = includeAudio ?? true @@ -319,16 +319,6 @@ final class ScreenRecordService: @unchecked Sendable { } } - private nonisolated static func clampDurationMs(_ ms: Int?) -> Int { - let v = ms ?? 10000 - return min(60000, max(250, v)) - } - - private nonisolated static func clampFps(_ fps: Double?) -> Double { - let v = fps ?? 10 - if !v.isFinite { return 10 } - return min(30, max(1, v)) - } } @MainActor @@ -350,11 +340,11 @@ private func stopReplayKitCapture(_ completion: @escaping @Sendable (Error?) -> #if DEBUG extension ScreenRecordService { nonisolated static func _test_clampDurationMs(_ ms: Int?) -> Int { - self.clampDurationMs(ms) + CaptureRateLimits.clampDurationMs(ms) } nonisolated static func _test_clampFps(_ fps: Double?) -> Double { - self.clampFps(fps) + CaptureRateLimits.clampFps(fps, maxFps: 30) } } #endif diff --git a/apps/ios/Sources/Status/GatewayActionsDialog.swift b/apps/ios/Sources/Status/GatewayActionsDialog.swift new file mode 100644 index 000000000..8c1ec42f3 --- /dev/null +++ b/apps/ios/Sources/Status/GatewayActionsDialog.swift @@ -0,0 +1,25 @@ +import SwiftUI + +extension View { + func gatewayActionsDialog( + isPresented: Binding, + onDisconnect: @escaping () -> Void, + onOpenSettings: @escaping () -> Void) -> some View + { + self.confirmationDialog( + "Gateway", + isPresented: isPresented, + titleVisibility: .visible) + { + Button("Disconnect", role: .destructive) { + onDisconnect() + } + Button("Open Settings") { + onOpenSettings() + } + Button("Cancel", role: .cancel) {} + } message: { + Text("Disconnect from the gateway?") + } + } +} diff --git a/apps/ios/Sources/Status/GatewayStatusBuilder.swift b/apps/ios/Sources/Status/GatewayStatusBuilder.swift new file mode 100644 index 000000000..dd15f5865 --- /dev/null +++ b/apps/ios/Sources/Status/GatewayStatusBuilder.swift @@ -0,0 +1,21 @@ +import Foundation + +enum GatewayStatusBuilder { + @MainActor + static func build(appModel: NodeAppModel) -> StatusPill.GatewayState { + if appModel.gatewayServerName != nil { return .connected } + + let text = appModel.gatewayStatusText.trimmingCharacters(in: .whitespacesAndNewlines) + if text.localizedCaseInsensitiveContains("connecting") || + text.localizedCaseInsensitiveContains("reconnecting") + { + return .connecting + } + + if text.localizedCaseInsensitiveContains("error") { + return .error + } + + return .disconnected + } +} diff --git a/apps/ios/Sources/Status/StatusGlassCard.swift b/apps/ios/Sources/Status/StatusGlassCard.swift new file mode 100644 index 000000000..6ee9ae0e4 --- /dev/null +++ b/apps/ios/Sources/Status/StatusGlassCard.swift @@ -0,0 +1,39 @@ +import SwiftUI + +private struct StatusGlassCardModifier: ViewModifier { + @Environment(\.colorSchemeContrast) private var contrast + + let brighten: Bool + let verticalPadding: CGFloat + let horizontalPadding: CGFloat + + func body(content: Content) -> some View { + content + .padding(.vertical, self.verticalPadding) + .padding(.horizontal, self.horizontalPadding) + .background { + RoundedRectangle(cornerRadius: 14, style: .continuous) + .fill(.ultraThinMaterial) + .overlay { + RoundedRectangle(cornerRadius: 14, style: .continuous) + .strokeBorder( + .white.opacity(self.contrast == .increased ? 0.5 : (self.brighten ? 0.24 : 0.18)), + lineWidth: self.contrast == .increased ? 1.0 : 0.5 + ) + } + .shadow(color: .black.opacity(0.25), radius: 12, y: 6) + } + } +} + +extension View { + func statusGlassCard(brighten: Bool, verticalPadding: CGFloat, horizontalPadding: CGFloat = 12) -> some View { + self.modifier( + StatusGlassCardModifier( + brighten: brighten, + verticalPadding: verticalPadding, + horizontalPadding: horizontalPadding + ) + ) + } +} diff --git a/apps/ios/Sources/Status/StatusPill.swift b/apps/ios/Sources/Status/StatusPill.swift index 8c0885fc5..a723ce5eb 100644 --- a/apps/ios/Sources/Status/StatusPill.swift +++ b/apps/ios/Sources/Status/StatusPill.swift @@ -3,7 +3,6 @@ import SwiftUI struct StatusPill: View { @Environment(\.scenePhase) private var scenePhase @Environment(\.accessibilityReduceMotion) private var reduceMotion - @Environment(\.colorSchemeContrast) private var contrast enum GatewayState: Equatable { case connected @@ -86,20 +85,7 @@ struct StatusPill: View { .transition(.opacity.combined(with: .move(edge: .top))) } } - .padding(.vertical, 8) - .padding(.horizontal, 12) - .background { - RoundedRectangle(cornerRadius: 14, style: .continuous) - .fill(.ultraThinMaterial) - .overlay { - RoundedRectangle(cornerRadius: 14, style: .continuous) - .strokeBorder( - .white.opacity(self.contrast == .increased ? 0.5 : (self.brighten ? 0.24 : 0.18)), - lineWidth: self.contrast == .increased ? 1.0 : 0.5 - ) - } - .shadow(color: .black.opacity(0.25), radius: 12, y: 6) - } + .statusGlassCard(brighten: self.brighten, verticalPadding: 8) } .buttonStyle(.plain) .accessibilityLabel("Connection Status") diff --git a/apps/ios/Sources/Status/VoiceWakeToast.swift b/apps/ios/Sources/Status/VoiceWakeToast.swift index ef6fc1295..251b2f551 100644 --- a/apps/ios/Sources/Status/VoiceWakeToast.swift +++ b/apps/ios/Sources/Status/VoiceWakeToast.swift @@ -1,8 +1,6 @@ import SwiftUI struct VoiceWakeToast: View { - @Environment(\.colorSchemeContrast) private var contrast - var command: String var brighten: Bool = false @@ -18,20 +16,7 @@ struct VoiceWakeToast: View { .lineLimit(1) .truncationMode(.tail) } - .padding(.vertical, 10) - .padding(.horizontal, 12) - .background { - RoundedRectangle(cornerRadius: 14, style: .continuous) - .fill(.ultraThinMaterial) - .overlay { - RoundedRectangle(cornerRadius: 14, style: .continuous) - .strokeBorder( - .white.opacity(self.contrast == .increased ? 0.5 : (self.brighten ? 0.24 : 0.18)), - lineWidth: self.contrast == .increased ? 1.0 : 0.5 - ) - } - .shadow(color: .black.opacity(0.25), radius: 12, y: 6) - } + .statusGlassCard(brighten: self.brighten, verticalPadding: 10) .accessibilityLabel("Voice Wake triggered") .accessibilityValue("Command: \(self.command)") } diff --git a/apps/ios/Sources/Voice/VoiceWakeManager.swift b/apps/ios/Sources/Voice/VoiceWakeManager.swift index 3a5b75859..cf0898e64 100644 --- a/apps/ios/Sources/Voice/VoiceWakeManager.swift +++ b/apps/ios/Sources/Voice/VoiceWakeManager.swift @@ -216,22 +216,7 @@ final class VoiceWakeManager: NSObject { self.isEnabled = false self.isListening = false self.statusText = "Off" - - self.tapDrainTask?.cancel() - self.tapDrainTask = nil - self.tapQueue?.clear() - self.tapQueue = nil - - self.recognitionTask?.cancel() - self.recognitionTask = nil - self.recognitionRequest = nil - - if self.audioEngine.isRunning { - self.audioEngine.stop() - self.audioEngine.inputNode.removeTap(onBus: 0) - } - - try? AVAudioSession.sharedInstance().setActive(false, options: .notifyOthersOnDeactivation) + self.tearDownRecognitionPipeline() } /// Temporarily releases the microphone so other subsystems (e.g. camera video capture) can record audio. @@ -241,22 +226,7 @@ final class VoiceWakeManager: NSObject { self.isListening = false self.statusText = "Paused" - - self.tapDrainTask?.cancel() - self.tapDrainTask = nil - self.tapQueue?.clear() - self.tapQueue = nil - - self.recognitionTask?.cancel() - self.recognitionTask = nil - self.recognitionRequest = nil - - if self.audioEngine.isRunning { - self.audioEngine.stop() - self.audioEngine.inputNode.removeTap(onBus: 0) - } - - try? AVAudioSession.sharedInstance().setActive(false, options: .notifyOthersOnDeactivation) + self.tearDownRecognitionPipeline() return true } @@ -310,6 +280,24 @@ final class VoiceWakeManager: NSObject { } } + private func tearDownRecognitionPipeline() { + self.tapDrainTask?.cancel() + self.tapDrainTask = nil + self.tapQueue?.clear() + self.tapQueue = nil + + self.recognitionTask?.cancel() + self.recognitionTask = nil + self.recognitionRequest = nil + + if self.audioEngine.isRunning { + self.audioEngine.stop() + self.audioEngine.inputNode.removeTap(onBus: 0) + } + + try? AVAudioSession.sharedInstance().setActive(false, options: .notifyOthersOnDeactivation) + } + private nonisolated func makeRecognitionResultHandler() -> @Sendable (SFSpeechRecognitionResult?, Error?) -> Void { { [weak self] result, error in let transcript = result?.bestTranscription.formattedString @@ -404,16 +392,10 @@ final class VoiceWakeManager: NSObject { } private nonisolated static func microphonePermissionMessage(kind: String) -> String { - switch AVAudioApplication.shared.recordPermission { - case .denied: - return "\(kind) permission denied" - case .undetermined: - return "\(kind) permission not granted" - case .granted: - return "\(kind) permission denied" - @unknown default: - return "\(kind) permission denied" - } + let status = AVAudioApplication.shared.recordPermission + return self.deniedByDefaultPermissionMessage( + kind: kind, + isUndetermined: status == .undetermined) } private nonisolated static func requestSpeechPermission() async -> Bool { @@ -463,16 +445,7 @@ final class VoiceWakeManager: NSObject { kind: String, status: AVAudioSession.RecordPermission) -> String { - switch status { - case .denied: - return "\(kind) permission denied" - case .undetermined: - return "\(kind) permission not granted" - case .granted: - return "\(kind) permission denied" - @unknown default: - return "\(kind) permission denied" - } + self.deniedByDefaultPermissionMessage(kind: kind, isUndetermined: status == .undetermined) } private static func permissionMessage( @@ -492,6 +465,13 @@ final class VoiceWakeManager: NSObject { return "\(kind) permission denied" } } + + private static func deniedByDefaultPermissionMessage(kind: String, isUndetermined: Bool) -> String { + if isUndetermined { + return "\(kind) permission not granted" + } + return "\(kind) permission denied" + } } #if DEBUG