From d6ad647f56f23d9396b504c29ac2f4e9e941451d Mon Sep 17 00:00:00 2001 From: Peter Steinberger Date: Sat, 21 Feb 2026 21:55:57 +0000 Subject: [PATCH] test(cli): share nodes ios fixture helpers --- src/cli/program.nodes-basic.e2e.test.ts | 13 ++----------- src/cli/program.nodes-media.e2e.test.ts | 13 ++----------- src/cli/program.nodes-test-helpers.test.ts | 12 ++++++++++++ src/cli/program.nodes-test-helpers.ts | 13 +++++++++++++ 4 files changed, 29 insertions(+), 22 deletions(-) create mode 100644 src/cli/program.nodes-test-helpers.test.ts create mode 100644 src/cli/program.nodes-test-helpers.ts diff --git a/src/cli/program.nodes-basic.e2e.test.ts b/src/cli/program.nodes-basic.e2e.test.ts index 5459c7d52..6124e6e2f 100644 --- a/src/cli/program.nodes-basic.e2e.test.ts +++ b/src/cli/program.nodes-basic.e2e.test.ts @@ -1,4 +1,5 @@ import { beforeEach, describe, expect, it, vi } from "vitest"; +import { createIosNodeListResponse } from "./program.nodes-test-helpers.js"; import { callGateway, installBaseProgramMocks, runTui, runtime } from "./program.test-mocks.js"; installBaseProgramMocks(); @@ -42,17 +43,7 @@ describe("cli program (nodes basics)", () => { callGateway.mockImplementation(async (...args: unknown[]) => { const opts = (args[0] ?? {}) as { method?: string }; if (opts.method === "node.list") { - return { - ts: Date.now(), - nodes: [ - { - nodeId: "ios-node", - displayName: "iOS Node", - remoteIp: "192.168.0.88", - connected: true, - }, - ], - }; + return createIosNodeListResponse(); } if (opts.method === method) { return result; diff --git a/src/cli/program.nodes-media.e2e.test.ts b/src/cli/program.nodes-media.e2e.test.ts index 342d41dd3..13f731f7a 100644 --- a/src/cli/program.nodes-media.e2e.test.ts +++ b/src/cli/program.nodes-media.e2e.test.ts @@ -1,6 +1,7 @@ import * as fs from "node:fs/promises"; import { afterAll, beforeAll, beforeEach, describe, expect, it, vi } from "vitest"; import { parseCameraSnapPayload, parseCameraClipPayload } from "./nodes-camera.js"; +import { IOS_NODE, createIosNodeListResponse } from "./program.nodes-test-helpers.js"; import { callGateway, installBaseProgramMocks, runTui, runtime } from "./program.test-mocks.js"; installBaseProgramMocks(); @@ -48,21 +49,11 @@ function expectParserRejectsMissingMedia( expect(() => parse(payload)).toThrow(expectedMessage); } -const IOS_NODE = { - nodeId: "ios-node", - displayName: "iOS Node", - remoteIp: "192.168.0.88", - connected: true, -} as const; - function mockNodeGateway(command?: string, payload?: Record) { callGateway.mockImplementation(async (...args: unknown[]) => { const opts = (args[0] ?? {}) as { method?: string }; if (opts.method === "node.list") { - return { - ts: Date.now(), - nodes: [IOS_NODE], - }; + return createIosNodeListResponse(); } if (opts.method === "node.invoke" && command) { return { diff --git a/src/cli/program.nodes-test-helpers.test.ts b/src/cli/program.nodes-test-helpers.test.ts new file mode 100644 index 000000000..81db08657 --- /dev/null +++ b/src/cli/program.nodes-test-helpers.test.ts @@ -0,0 +1,12 @@ +import { describe, expect, it } from "vitest"; +import { IOS_NODE, createIosNodeListResponse } from "./program.nodes-test-helpers.js"; + +describe("program.nodes-test-helpers", () => { + it("builds a node.list response with iOS node fixture", () => { + const response = createIosNodeListResponse(1234); + expect(response).toEqual({ + ts: 1234, + nodes: [IOS_NODE], + }); + }); +}); diff --git a/src/cli/program.nodes-test-helpers.ts b/src/cli/program.nodes-test-helpers.ts new file mode 100644 index 000000000..428c7bf79 --- /dev/null +++ b/src/cli/program.nodes-test-helpers.ts @@ -0,0 +1,13 @@ +export const IOS_NODE = { + nodeId: "ios-node", + displayName: "iOS Node", + remoteIp: "192.168.0.88", + connected: true, +} as const; + +export function createIosNodeListResponse(ts: number = Date.now()) { + return { + ts, + nodes: [IOS_NODE], + }; +}