Moltbot

admin/Moltbot

Fork 0

Commit Graph

Author	SHA1	Message	Date
Sebastian	fb996031bc	fix(process): harden graceful kill-tree cancellation semantics	2026-02-16 20:37:08 -05:00
Daniel Sauer	20957efa46	fix(process): graceful process tree termination with SIGTERM before SIGKILL Process trees (pty sessions, tool exec) were being SIGKILL'd immediately without any grace period for cleanup. This prevented child processes from: - Flushing buffers and closing files cleanly - Closing network connections - Terminating their own child processes - Removing temporary files Changes: - Send SIGTERM to process group first (Unix) - Wait configurable grace period (default 3s) - Then SIGKILL if process still alive - Windows: taskkill without /F first, then with /F after grace period - Use unref() on timeout to not block event loop exit Fixes #18619 Co-authored-by: James <james@openclaw.ai>	2026-02-16 23:49:44 +01:00
Onur	cd44a0d01e	fix: codex and similar processes keep dying on pty, solved by refactoring process spawning (#14257 ) * exec: clean up PTY resources on timeout and exit * cli: harden resume cleanup and watchdog stalled runs * cli: productionize PTY and resume reliability paths * docs: add PTY process supervision architecture plan * docs: rewrite PTY supervision plan as pre-rewrite baseline * docs: switch PTY supervision plan to one-go execution * docs: add one-line root cause to PTY supervision plan * docs: add OS contracts and test matrix to PTY supervision plan * docs: define process-supervisor package placement and scope * docs: tie supervisor plan to existing CI lanes * docs: place PTY supervisor plan under src/process * refactor(process): route exec and cli runs through supervisor * docs(process): refresh PTY supervision plan * wip * fix(process): harden supervisor timeout and PTY termination * fix(process): harden supervisor adapters env and wait handling * ci: avoid failing formal conformance on comment permissions * test(ui): fix cron request mock argument typing * fix(ui): remove leftover conflict marker * fix: supervise PTY processes (#14257) (openclaw#14257) (thanks @onutc)	2026-02-16 02:32:05 +01:00

Author

SHA1

Message

Date

Sebastian

fb996031bc

fix(process): harden graceful kill-tree cancellation semantics

2026-02-16 20:37:08 -05:00

Daniel Sauer

20957efa46

fix(process): graceful process tree termination with SIGTERM before SIGKILL

Process trees (pty sessions, tool exec) were being SIGKILL'd immediately
without any grace period for cleanup. This prevented child processes from:
- Flushing buffers and closing files cleanly
- Closing network connections
- Terminating their own child processes
- Removing temporary files

Changes:
- Send SIGTERM to process group first (Unix)
- Wait configurable grace period (default 3s)
- Then SIGKILL if process still alive
- Windows: taskkill without /F first, then with /F after grace period
- Use unref() on timeout to not block event loop exit

Fixes #18619

Co-authored-by: James <james@openclaw.ai>

2026-02-16 23:49:44 +01:00

Onur

cd44a0d01e

fix: codex and similar processes keep dying on pty, solved by refactoring process spawning (#14257 )

* exec: clean up PTY resources on timeout and exit

* cli: harden resume cleanup and watchdog stalled runs

* cli: productionize PTY and resume reliability paths

* docs: add PTY process supervision architecture plan

* docs: rewrite PTY supervision plan as pre-rewrite baseline

* docs: switch PTY supervision plan to one-go execution

* docs: add one-line root cause to PTY supervision plan

* docs: add OS contracts and test matrix to PTY supervision plan

* docs: define process-supervisor package placement and scope

* docs: tie supervisor plan to existing CI lanes

* docs: place PTY supervisor plan under src/process

* refactor(process): route exec and cli runs through supervisor

* docs(process): refresh PTY supervision plan

* wip

* fix(process): harden supervisor timeout and PTY termination

* fix(process): harden supervisor adapters env and wait handling

* ci: avoid failing formal conformance on comment permissions

* test(ui): fix cron request mock argument typing

* fix(ui): remove leftover conflict marker

* fix: supervise PTY processes (#14257) (openclaw#14257) (thanks @onutc)

2026-02-16 02:32:05 +01:00

3 Commits