import { describe, expect, it } from "vitest"; import { normalizeCronJobCreate, normalizeCronJobPatch } from "./normalize.js"; import { DEFAULT_TOP_OF_HOUR_STAGGER_MS } from "./stagger.js"; function expectNormalizedAtSchedule(scheduleInput: Record) { const normalized = normalizeCronJobCreate({ name: "iso schedule", enabled: true, schedule: scheduleInput, sessionTarget: "main", wakeMode: "next-heartbeat", payload: { kind: "systemEvent", text: "hi", }, }) as unknown as Record; const schedule = normalized.schedule as Record; expect(schedule.kind).toBe("at"); expect(schedule.at).toBe(new Date(Date.parse("2026-01-12T18:00:00Z")).toISOString()); } describe("normalizeCronJobCreate", () => { it("maps legacy payload.provider to payload.channel and strips provider", () => { const normalized = normalizeCronJobCreate({ name: "legacy", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, sessionTarget: "isolated", wakeMode: "now", payload: { kind: "agentTurn", message: "hi", deliver: true, provider: " TeLeGrAm ", to: "7200373102", }, }) as unknown as Record; const payload = normalized.payload as Record; expect(payload.channel).toBeUndefined(); expect(payload.deliver).toBeUndefined(); expect("provider" in payload).toBe(false); const delivery = normalized.delivery as Record; expect(delivery.mode).toBe("announce"); expect(delivery.channel).toBe("telegram"); expect(delivery.to).toBe("7200373102"); }); it("trims agentId and drops null", () => { const normalized = normalizeCronJobCreate({ name: "agent-set", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, sessionTarget: "isolated", wakeMode: "now", agentId: " Ops ", payload: { kind: "agentTurn", message: "hi", }, }) as unknown as Record; expect(normalized.agentId).toBe("ops"); const cleared = normalizeCronJobCreate({ name: "agent-clear", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, sessionTarget: "isolated", wakeMode: "now", agentId: null, payload: { kind: "agentTurn", message: "hi", }, }) as unknown as Record; expect(cleared.agentId).toBeNull(); }); it("trims sessionKey and drops blanks", () => { const normalized = normalizeCronJobCreate({ name: "session-key", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, sessionTarget: "main", wakeMode: "next-heartbeat", sessionKey: " agent:main:discord:channel:ops ", payload: { kind: "systemEvent", text: "hi" }, }) as unknown as Record; expect(normalized.sessionKey).toBe("agent:main:discord:channel:ops"); const cleared = normalizeCronJobCreate({ name: "session-key-clear", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, sessionTarget: "main", wakeMode: "next-heartbeat", sessionKey: " ", payload: { kind: "systemEvent", text: "hi" }, }) as unknown as Record; expect("sessionKey" in cleared).toBe(false); }); it("canonicalizes payload.channel casing", () => { const normalized = normalizeCronJobCreate({ name: "legacy provider", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, sessionTarget: "isolated", wakeMode: "now", payload: { kind: "agentTurn", message: "hi", deliver: true, channel: "Telegram", to: "7200373102", }, }) as unknown as Record; const payload = normalized.payload as Record; expect(payload.channel).toBeUndefined(); expect(payload.deliver).toBeUndefined(); const delivery = normalized.delivery as Record; expect(delivery.mode).toBe("announce"); expect(delivery.channel).toBe("telegram"); expect(delivery.to).toBe("7200373102"); }); it("coerces ISO schedule.at to normalized ISO (UTC)", () => { expectNormalizedAtSchedule({ at: "2026-01-12T18:00:00" }); }); it("coerces schedule.atMs string to schedule.at (UTC)", () => { expectNormalizedAtSchedule({ kind: "at", atMs: "2026-01-12T18:00:00" }); }); it("defaults cron stagger for recurring top-of-hour schedules", () => { const normalized = normalizeCronJobCreate({ name: "hourly", enabled: true, schedule: { kind: "cron", expr: "0 * * * *", tz: "UTC" }, sessionTarget: "main", wakeMode: "next-heartbeat", payload: { kind: "systemEvent", text: "tick", }, }) as unknown as Record; const schedule = normalized.schedule as Record; expect(schedule.staggerMs).toBe(DEFAULT_TOP_OF_HOUR_STAGGER_MS); }); it("preserves explicit exact cron schedule", () => { const normalized = normalizeCronJobCreate({ name: "exact", enabled: true, schedule: { kind: "cron", expr: "0 * * * *", tz: "UTC", staggerMs: 0 }, sessionTarget: "main", wakeMode: "next-heartbeat", payload: { kind: "systemEvent", text: "tick", }, }) as unknown as Record; const schedule = normalized.schedule as Record; expect(schedule.staggerMs).toBe(0); }); it("defaults deleteAfterRun for one-shot schedules", () => { const normalized = normalizeCronJobCreate({ name: "default delete", enabled: true, schedule: { at: "2026-01-12T18:00:00Z" }, sessionTarget: "main", wakeMode: "next-heartbeat", payload: { kind: "systemEvent", text: "hi", }, }) as unknown as Record; expect(normalized.deleteAfterRun).toBe(true); }); it("normalizes delivery mode and channel", () => { const normalized = normalizeCronJobCreate({ name: "delivery", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, sessionTarget: "isolated", wakeMode: "now", payload: { kind: "agentTurn", message: "hi", }, delivery: { mode: " ANNOUNCE ", channel: " TeLeGrAm ", to: " 7200373102 ", }, }) as unknown as Record; const delivery = normalized.delivery as Record; expect(delivery.mode).toBe("announce"); expect(delivery.channel).toBe("telegram"); expect(delivery.to).toBe("7200373102"); }); it("normalizes webhook delivery mode and target URL", () => { const normalized = normalizeCronJobCreate({ name: "webhook delivery", enabled: true, schedule: { kind: "every", everyMs: 60_000 }, sessionTarget: "main", wakeMode: "now", payload: { kind: "systemEvent", text: "hello" }, delivery: { mode: " WeBhOoK ", to: " https://example.invalid/cron ", }, }) as unknown as Record; const delivery = normalized.delivery as Record; expect(delivery.mode).toBe("webhook"); expect(delivery.to).toBe("https://example.invalid/cron"); }); it("defaults isolated agentTurn delivery to announce", () => { const normalized = normalizeCronJobCreate({ name: "default-announce", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, payload: { kind: "agentTurn", message: "hi", }, }) as unknown as Record; const delivery = normalized.delivery as Record; expect(delivery.mode).toBe("announce"); }); it("migrates legacy delivery fields to delivery", () => { const normalized = normalizeCronJobCreate({ name: "legacy deliver", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, payload: { kind: "agentTurn", message: "hi", deliver: true, channel: "telegram", to: "7200373102", bestEffortDeliver: true, }, }) as unknown as Record; const delivery = normalized.delivery as Record; expect(delivery.mode).toBe("announce"); expect(delivery.channel).toBe("telegram"); expect(delivery.to).toBe("7200373102"); expect(delivery.bestEffort).toBe(true); }); it("maps legacy deliver=false to delivery none", () => { const normalized = normalizeCronJobCreate({ name: "legacy off", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, payload: { kind: "agentTurn", message: "hi", deliver: false, channel: "telegram", to: "7200373102", }, }) as unknown as Record; const delivery = normalized.delivery as Record; expect(delivery.mode).toBe("none"); }); it("migrates legacy isolation settings to announce delivery", () => { const normalized = normalizeCronJobCreate({ name: "legacy isolation", enabled: true, schedule: { kind: "cron", expr: "* * * * *" }, payload: { kind: "agentTurn", message: "hi", }, isolation: { postToMainPrefix: "Cron" }, }) as unknown as Record; const delivery = normalized.delivery as Record; expect(delivery.mode).toBe("announce"); expect((normalized as { isolation?: unknown }).isolation).toBeUndefined(); }); it("infers payload kind/session target and name for message-only jobs", () => { const normalized = normalizeCronJobCreate({ schedule: { kind: "every", everyMs: 60_000 }, payload: { message: "Nightly backup" }, }) as unknown as Record; const payload = normalized.payload as Record; expect(payload.kind).toBe("agentTurn"); expect(payload.message).toBe("Nightly backup"); expect(normalized.sessionTarget).toBe("isolated"); expect(normalized.wakeMode).toBe("now"); expect(typeof normalized.name).toBe("string"); }); it("maps top-level model/thinking/timeout into payload for legacy add params", () => { const normalized = normalizeCronJobCreate({ name: "legacy root fields", schedule: { kind: "every", everyMs: 60_000 }, payload: { kind: "agentTurn", message: "hello" }, model: " openrouter/deepseek/deepseek-r1 ", thinking: " high ", timeoutSeconds: 45, allowUnsafeExternalContent: true, }) as unknown as Record; const payload = normalized.payload as Record; expect(payload.model).toBe("openrouter/deepseek/deepseek-r1"); expect(payload.thinking).toBe("high"); expect(payload.timeoutSeconds).toBe(45); expect(payload.allowUnsafeExternalContent).toBe(true); }); it("preserves timeoutSeconds=0 for no-timeout agentTurn payloads", () => { const normalized = normalizeCronJobCreate({ name: "legacy no-timeout", schedule: { kind: "every", everyMs: 60_000 }, payload: { kind: "agentTurn", message: "hello" }, timeoutSeconds: 0, }) as unknown as Record; const payload = normalized.payload as Record; expect(payload.timeoutSeconds).toBe(0); }); it("coerces sessionTarget and wakeMode casing", () => { const normalized = normalizeCronJobCreate({ name: "casing", schedule: { kind: "cron", expr: "* * * * *" }, sessionTarget: " IsOlAtEd ", wakeMode: " NOW ", payload: { kind: "agentTurn", message: "hello" }, }) as unknown as Record; expect(normalized.sessionTarget).toBe("isolated"); expect(normalized.wakeMode).toBe("now"); }); it("strips invalid delivery mode from partial delivery objects", () => { const normalized = normalizeCronJobCreate({ name: "delivery mode", schedule: { kind: "cron", expr: "* * * * *" }, payload: { kind: "agentTurn", message: "hello" }, delivery: { mode: "bogus", to: "123" }, }) as unknown as Record; const delivery = normalized.delivery as Record; expect(delivery.mode).toBeUndefined(); expect(delivery.to).toBe("123"); }); }); describe("normalizeCronJobPatch", () => { it("infers agentTurn kind for model-only payload patches", () => { const normalized = normalizeCronJobPatch({ payload: { model: "anthropic/claude-sonnet-4-5", }, }) as unknown as Record; const payload = normalized.payload as Record; expect(payload.kind).toBe("agentTurn"); expect(payload.model).toBe("anthropic/claude-sonnet-4-5"); }); it("does not infer agentTurn kind for delivery-only legacy hints", () => { const normalized = normalizeCronJobPatch({ payload: { channel: "telegram", to: "+15550001111", }, }) as unknown as Record; const payload = normalized.payload as Record; expect(payload.kind).toBeUndefined(); expect(payload.channel).toBe("telegram"); expect(payload.to).toBe("+15550001111"); }); it("preserves null sessionKey patches and trims string values", () => { const trimmed = normalizeCronJobPatch({ sessionKey: " agent:main:telegram:group:-100123 ", }) as unknown as Record; expect(trimmed.sessionKey).toBe("agent:main:telegram:group:-100123"); const cleared = normalizeCronJobPatch({ sessionKey: null, }) as unknown as Record; expect(cleared.sessionKey).toBeNull(); }); it("normalizes cron stagger values in patch schedules", () => { const normalized = normalizeCronJobPatch({ schedule: { kind: "cron", expr: "0 * * * *", staggerMs: "30000" }, }) as unknown as Record; const schedule = normalized.schedule as Record; expect(schedule.staggerMs).toBe(30_000); }); });