Files
Moltbot/src/utils/utils-misc.test.ts
Byungsker 17578d77e1 fix(agents): add forward-compat fallback for google-gemini-cli gemini-3.1-pro/flash-preview (#26570)
* fix(agents): add "google" provider to isReasoningTagProvider to prevent reasoning leak

The gemini-api-key auth flow creates a profile with provider "google"
(e.g. google/gemini-3-pro-preview), but isReasoningTagProvider only
matched "google-gemini-cli" (OAuth) and "google-generative-ai". As a
result:
- reasoningTagHint was false → system prompt omitted <think>/<final>
  formatting instructions
- enforceFinalTag was false → <final> tag filtering was skipped

Raw <think> reasoning output was delivered to the end user.

Fix: add the bare "google" provider string to the match list and cover
it with two new test cases (exact match + case-insensitive).

Fixes #26551

* fix(agents): add forward-compat fallback for google-gemini-cli gemini-3.1-pro/flash-preview

gemini-3.1-pro-preview and gemini-3.1-flash-preview are not yet present in
pi-ai's built-in google-gemini-cli model catalog (only gemini-3-pro-preview
and gemini-3-flash-preview are registered). When users configure these models
they get "Unknown model" errors even though Gemini CLI OAuth supports them.

The codebase already has isGemini31Model() in extra-params.ts, which proves
intent to support these models. Add a resolveGoogleGeminiCli31ForwardCompatModel
entry to resolveForwardCompatModel following the same clone-template pattern
used for zai/glm-5 and anthropic 4.6 models.

- gemini-3.1-pro-* clones gemini-3-pro-preview (with reasoning: true)
- gemini-3.1-flash-* clones gemini-3-flash-preview (with reasoning: true)

Also add test helpers and three test cases to model.forward-compat.test.ts.

Fixes #26524

* Changelog: credit Google Gemini provider fallback fixes

---------

Co-authored-by: Vincent Koc <vincentkoc@ieee.org>
2026-02-26 18:39:13 -05:00

110 lines
3.6 KiB
TypeScript

import { describe, expect, it } from "vitest";
import { parseBooleanValue } from "./boolean.js";
import { isReasoningTagProvider } from "./provider-utils.js";
import { splitShellArgs } from "./shell-argv.js";
describe("parseBooleanValue", () => {
it("handles boolean inputs", () => {
expect(parseBooleanValue(true)).toBe(true);
expect(parseBooleanValue(false)).toBe(false);
});
it("parses default truthy/falsy strings", () => {
expect(parseBooleanValue("true")).toBe(true);
expect(parseBooleanValue("1")).toBe(true);
expect(parseBooleanValue("yes")).toBe(true);
expect(parseBooleanValue("on")).toBe(true);
expect(parseBooleanValue("false")).toBe(false);
expect(parseBooleanValue("0")).toBe(false);
expect(parseBooleanValue("no")).toBe(false);
expect(parseBooleanValue("off")).toBe(false);
});
it("respects custom truthy/falsy lists", () => {
expect(
parseBooleanValue("on", {
truthy: ["true"],
falsy: ["false"],
}),
).toBeUndefined();
expect(
parseBooleanValue("yes", {
truthy: ["yes"],
falsy: ["no"],
}),
).toBe(true);
});
it("returns undefined for unsupported values", () => {
expect(parseBooleanValue("")).toBeUndefined();
expect(parseBooleanValue("maybe")).toBeUndefined();
expect(parseBooleanValue(1)).toBeUndefined();
});
});
describe("isReasoningTagProvider", () => {
const cases: Array<{
name: string;
value: string | null | undefined;
expected: boolean;
}> = [
{
name: "returns false for ollama - native reasoning field, no tags needed (#2279)",
value: "ollama",
expected: false,
},
{
name: "returns false for case-insensitive ollama",
value: "Ollama",
expected: false,
},
{
name: "returns true for google (gemini-api-key auth provider)",
value: "google",
expected: true,
},
{
name: "returns true for Google (case-insensitive)",
value: "Google",
expected: true,
},
{ name: "returns true for google-gemini-cli", value: "google-gemini-cli", expected: true },
{
name: "returns true for google-generative-ai",
value: "google-generative-ai",
expected: true,
},
{ name: "returns true for minimax", value: "minimax", expected: true },
{ name: "returns true for minimax-cn", value: "minimax-cn", expected: true },
{ name: "returns false for null", value: null, expected: false },
{ name: "returns false for undefined", value: undefined, expected: false },
{ name: "returns false for empty", value: "", expected: false },
{ name: "returns false for anthropic", value: "anthropic", expected: false },
{ name: "returns false for openai", value: "openai", expected: false },
{ name: "returns false for openrouter", value: "openrouter", expected: false },
];
for (const testCase of cases) {
it(testCase.name, () => {
expect(isReasoningTagProvider(testCase.value)).toBe(testCase.expected);
});
}
});
describe("splitShellArgs", () => {
it("splits whitespace and respects quotes", () => {
expect(splitShellArgs(`qmd --foo "bar baz"`)).toEqual(["qmd", "--foo", "bar baz"]);
expect(splitShellArgs(`qmd --foo 'bar baz'`)).toEqual(["qmd", "--foo", "bar baz"]);
});
it("supports backslash escapes inside double quotes", () => {
expect(splitShellArgs(String.raw`echo "a\"b"`)).toEqual(["echo", `a"b`]);
expect(splitShellArgs(String.raw`echo "\$HOME"`)).toEqual(["echo", "$HOME"]);
});
it("returns null for unterminated quotes", () => {
expect(splitShellArgs(`echo "oops`)).toBeNull();
expect(splitShellArgs(`echo 'oops`)).toBeNull();
});
});