* feat(secrets): expand secret target coverage and gateway tooling * docs(secrets): align gateway and CLI secret docs * chore(protocol): regenerate swift gateway models for secrets methods * fix(config): restore talk apiKey fallback and stabilize runner test * ci(windows): reduce test worker count for shard stability * ci(windows): raise node heap for test shard stability * test(feishu): make proxy env precedence assertion windows-safe * fix(gateway): resolve auth password SecretInput refs for clients * fix(gateway): resolve remote SecretInput credentials for clients * fix(secrets): skip inactive refs in command snapshot assignments * fix(secrets): scope gateway.remote refs to effective auth surfaces * fix(secrets): ignore memory defaults when enabled agents disable search * fix(secrets): honor Google Chat serviceAccountRef inheritance * fix(secrets): address tsgo errors in command and gateway collectors * fix(secrets): avoid auth-store load in providers-only configure * fix(gateway): defer local password ref resolution by precedence * fix(secrets): gate telegram webhook secret refs by webhook mode * fix(secrets): gate slack signing secret refs to http mode * fix(secrets): skip telegram botToken refs when tokenFile is set * fix(secrets): gate discord pluralkit refs by enabled flag * fix(secrets): gate discord voice tts refs by voice enabled * test(secrets): make runtime fixture modes explicit * fix(cli): resolve local qr password secret refs * fix(cli): fail when gateway leaves command refs unresolved * fix(gateway): fail when local password SecretRef is unresolved * fix(gateway): fail when required remote SecretRefs are unresolved * fix(gateway): resolve local password refs only when password can win * fix(cli): skip local password SecretRef resolution on qr token override * test(gateway): cast SecretRef fixtures to OpenClawConfig * test(secrets): activate mode-gated targets in runtime coverage fixture * fix(cron): support SecretInput webhook tokens safely * fix(bluebubbles): support SecretInput passwords across config paths * fix(msteams): make appPassword SecretInput-safe in onboarding/token paths * fix(bluebubbles): align SecretInput schema helper typing * fix(cli): clarify secrets.resolve version-skew errors * refactor(secrets): return structured inactive paths from secrets.resolve * refactor(gateway): type onboarding secret writes as SecretInput * chore(protocol): regenerate swift models for secrets.resolve * feat(secrets): expand extension credential secretref support * fix(secrets): gate web-search refs by active provider * fix(onboarding): detect SecretRef credentials in extension status * fix(onboarding): allow keeping existing ref in secret prompt * fix(onboarding): resolve gateway password SecretRefs for probe and tui * fix(onboarding): honor secret-input-mode for local gateway auth * fix(acp): resolve gateway SecretInput credentials * fix(secrets): gate gateway.remote refs to remote surfaces * test(secrets): cover pattern matching and inactive array refs * docs(secrets): clarify secrets.resolve and remote active surfaces * fix(bluebubbles): keep existing SecretRef during onboarding * fix(tests): resolve CI type errors in new SecretRef coverage * fix(extensions): replace raw fetch with SSRF-guarded fetch * test(secrets): mark gateway remote targets active in runtime coverage * test(infra): normalize home-prefix expectation across platforms * fix(cli): only resolve local qr password refs in password mode * test(cli): cover local qr token mode with unresolved password ref * docs(cli): clarify local qr password ref resolution behavior * refactor(extensions): reuse sdk SecretInput helpers * fix(wizard): resolve onboarding env-template secrets before plaintext * fix(cli): surface secrets.resolve diagnostics in memory and qr * test(secrets): repair post-rebase runtime and fixtures * fix(gateway): skip remote password ref resolution when token wins * fix(secrets): treat tailscale remote gateway refs as active * fix(gateway): allow remote password fallback when token ref is unresolved * fix(gateway): ignore stale local password refs for none and trusted-proxy * fix(gateway): skip remote secret ref resolution on local call paths * test(cli): cover qr remote tailscale secret ref resolution * fix(secrets): align gateway password active-surface with auth inference * fix(cli): resolve inferred local gateway password refs in qr * fix(gateway): prefer resolvable remote password over token ref pre-resolution * test(gateway): cover none and trusted-proxy stale password refs * docs(secrets): sync qr and gateway active-surface behavior * fix: restore stability blockers from pre-release audit * Secrets: fix collector/runtime precedence contradictions * docs: align secrets and web credential docs * fix(rebase): resolve integration regressions after main rebase * fix(node-host): resolve gateway secret refs for auth * fix(secrets): harden secretinput runtime readers * gateway: skip inactive auth secretref resolution * cli: avoid gateway preflight for inactive secret refs * extensions: allow unresolved refs in onboarding status * tests: fix qr-cli module mock hoist ordering * Security: align audit checks with SecretInput resolution * Gateway: resolve local-mode remote fallback secret refs * Node host: avoid resolving inactive password secret refs * Secrets runtime: mark Slack appToken inactive for HTTP mode * secrets: keep inactive gateway remote refs non-blocking * cli: include agent memory secret targets in runtime resolution * docs(secrets): sync docs with active-surface and web search behavior * fix(secrets): keep telegram top-level token refs active for blank account tokens * fix(daemon): resolve gateway password secret refs for probe auth * fix(secrets): skip IRC NickServ ref resolution when NickServ is disabled * fix(secrets): align token inheritance and exec timeout defaults * docs(secrets): clarify active-surface notes in cli docs * cli: require secrets.resolve gateway capability * gateway: log auth secret surface diagnostics * secrets: remove dead provider resolver module * fix(secrets): restore gateway auth precedence and fallback resolution * fix(tests): align plugin runtime mock typings --------- Co-authored-by: Peter Steinberger <steipete@gmail.com>
342 lines
9.5 KiB
TypeScript
342 lines
9.5 KiB
TypeScript
import os from "node:os";
|
|
import { resolveGatewayPort } from "../config/paths.js";
|
|
import type { OpenClawConfig } from "../config/types.js";
|
|
import { normalizeSecretInputString, resolveSecretInputRef } from "../config/types.secrets.js";
|
|
import { secretRefKey } from "../secrets/ref-contract.js";
|
|
import { resolveSecretRefValues } from "../secrets/resolve.js";
|
|
import { resolveGatewayBindUrl } from "../shared/gateway-bind-url.js";
|
|
import { isCarrierGradeNatIpv4Address, isRfc1918Ipv4Address } from "../shared/net/ip.js";
|
|
import { resolveTailnetHostWithRunner } from "../shared/tailscale-status.js";
|
|
|
|
export type PairingSetupPayload = {
|
|
url: string;
|
|
token?: string;
|
|
password?: string;
|
|
};
|
|
|
|
export type PairingSetupCommandResult = {
|
|
code: number | null;
|
|
stdout: string;
|
|
stderr?: string;
|
|
};
|
|
|
|
export type PairingSetupCommandRunner = (
|
|
argv: string[],
|
|
opts: { timeoutMs: number },
|
|
) => Promise<PairingSetupCommandResult>;
|
|
|
|
export type ResolvePairingSetupOptions = {
|
|
env?: NodeJS.ProcessEnv;
|
|
publicUrl?: string;
|
|
preferRemoteUrl?: boolean;
|
|
forceSecure?: boolean;
|
|
runCommandWithTimeout?: PairingSetupCommandRunner;
|
|
networkInterfaces?: () => ReturnType<typeof os.networkInterfaces>;
|
|
};
|
|
|
|
export type PairingSetupResolution =
|
|
| {
|
|
ok: true;
|
|
payload: PairingSetupPayload;
|
|
authLabel: "token" | "password";
|
|
urlSource: string;
|
|
}
|
|
| {
|
|
ok: false;
|
|
error: string;
|
|
};
|
|
|
|
type ResolveUrlResult = {
|
|
url?: string;
|
|
source?: string;
|
|
error?: string;
|
|
};
|
|
|
|
type ResolveAuthResult = {
|
|
token?: string;
|
|
password?: string;
|
|
label?: "token" | "password";
|
|
error?: string;
|
|
};
|
|
|
|
function normalizeUrl(raw: string, schemeFallback: "ws" | "wss"): string | null {
|
|
const trimmed = raw.trim();
|
|
if (!trimmed) {
|
|
return null;
|
|
}
|
|
try {
|
|
const parsed = new URL(trimmed);
|
|
const scheme = parsed.protocol.replace(":", "");
|
|
if (!scheme) {
|
|
return null;
|
|
}
|
|
const resolvedScheme = scheme === "http" ? "ws" : scheme === "https" ? "wss" : scheme;
|
|
if (resolvedScheme !== "ws" && resolvedScheme !== "wss") {
|
|
return null;
|
|
}
|
|
const host = parsed.hostname;
|
|
if (!host) {
|
|
return null;
|
|
}
|
|
const port = parsed.port ? `:${parsed.port}` : "";
|
|
return `${resolvedScheme}://${host}${port}`;
|
|
} catch {
|
|
// Fall through to host:port parsing.
|
|
}
|
|
|
|
const withoutPath = trimmed.split("/")[0] ?? "";
|
|
if (!withoutPath) {
|
|
return null;
|
|
}
|
|
return `${schemeFallback}://${withoutPath}`;
|
|
}
|
|
|
|
function resolveScheme(
|
|
cfg: OpenClawConfig,
|
|
opts?: {
|
|
forceSecure?: boolean;
|
|
},
|
|
): "ws" | "wss" {
|
|
if (opts?.forceSecure) {
|
|
return "wss";
|
|
}
|
|
return cfg.gateway?.tls?.enabled === true ? "wss" : "ws";
|
|
}
|
|
|
|
function isPrivateIPv4(address: string): boolean {
|
|
return isRfc1918Ipv4Address(address);
|
|
}
|
|
|
|
function isTailnetIPv4(address: string): boolean {
|
|
return isCarrierGradeNatIpv4Address(address);
|
|
}
|
|
|
|
function pickIPv4Matching(
|
|
networkInterfaces: () => ReturnType<typeof os.networkInterfaces>,
|
|
matches: (address: string) => boolean,
|
|
): string | null {
|
|
const nets = networkInterfaces();
|
|
for (const entries of Object.values(nets)) {
|
|
if (!entries) {
|
|
continue;
|
|
}
|
|
for (const entry of entries) {
|
|
const family = entry?.family;
|
|
const isIpv4 = family === "IPv4";
|
|
if (!entry || entry.internal || !isIpv4) {
|
|
continue;
|
|
}
|
|
const address = entry.address?.trim() ?? "";
|
|
if (!address) {
|
|
continue;
|
|
}
|
|
if (matches(address)) {
|
|
return address;
|
|
}
|
|
}
|
|
}
|
|
return null;
|
|
}
|
|
|
|
function pickLanIPv4(
|
|
networkInterfaces: () => ReturnType<typeof os.networkInterfaces>,
|
|
): string | null {
|
|
return pickIPv4Matching(networkInterfaces, isPrivateIPv4);
|
|
}
|
|
|
|
function pickTailnetIPv4(
|
|
networkInterfaces: () => ReturnType<typeof os.networkInterfaces>,
|
|
): string | null {
|
|
return pickIPv4Matching(networkInterfaces, isTailnetIPv4);
|
|
}
|
|
|
|
function resolveAuth(cfg: OpenClawConfig, env: NodeJS.ProcessEnv): ResolveAuthResult {
|
|
const mode = cfg.gateway?.auth?.mode;
|
|
const token =
|
|
env.OPENCLAW_GATEWAY_TOKEN?.trim() ||
|
|
env.CLAWDBOT_GATEWAY_TOKEN?.trim() ||
|
|
cfg.gateway?.auth?.token?.trim();
|
|
const password =
|
|
env.OPENCLAW_GATEWAY_PASSWORD?.trim() ||
|
|
env.CLAWDBOT_GATEWAY_PASSWORD?.trim() ||
|
|
normalizeSecretInputString(cfg.gateway?.auth?.password);
|
|
|
|
if (mode === "password") {
|
|
if (!password) {
|
|
return { error: "Gateway auth is set to password, but no password is configured." };
|
|
}
|
|
return { password, label: "password" };
|
|
}
|
|
if (mode === "token") {
|
|
if (!token) {
|
|
return { error: "Gateway auth is set to token, but no token is configured." };
|
|
}
|
|
return { token, label: "token" };
|
|
}
|
|
if (token) {
|
|
return { token, label: "token" };
|
|
}
|
|
if (password) {
|
|
return { password, label: "password" };
|
|
}
|
|
return { error: "Gateway auth is not configured (no token or password)." };
|
|
}
|
|
|
|
async function resolveGatewayPasswordSecretRef(
|
|
cfg: OpenClawConfig,
|
|
env: NodeJS.ProcessEnv,
|
|
): Promise<OpenClawConfig> {
|
|
const authPassword = cfg.gateway?.auth?.password;
|
|
const { ref } = resolveSecretInputRef({
|
|
value: authPassword,
|
|
defaults: cfg.secrets?.defaults,
|
|
});
|
|
if (!ref) {
|
|
return cfg;
|
|
}
|
|
const hasPasswordEnvCandidate = Boolean(
|
|
env.OPENCLAW_GATEWAY_PASSWORD?.trim() || env.CLAWDBOT_GATEWAY_PASSWORD?.trim(),
|
|
);
|
|
if (hasPasswordEnvCandidate) {
|
|
return cfg;
|
|
}
|
|
const mode = cfg.gateway?.auth?.mode;
|
|
if (mode === "token" || mode === "none" || mode === "trusted-proxy") {
|
|
return cfg;
|
|
}
|
|
if (mode !== "password") {
|
|
const hasTokenCandidate =
|
|
Boolean(env.OPENCLAW_GATEWAY_TOKEN?.trim() || env.CLAWDBOT_GATEWAY_TOKEN?.trim()) ||
|
|
Boolean(cfg.gateway?.auth?.token?.trim());
|
|
if (hasTokenCandidate) {
|
|
return cfg;
|
|
}
|
|
}
|
|
const resolved = await resolveSecretRefValues([ref], {
|
|
config: cfg,
|
|
env,
|
|
});
|
|
const value = resolved.get(secretRefKey(ref));
|
|
if (typeof value !== "string" || value.trim().length === 0) {
|
|
throw new Error("gateway.auth.password resolved to an empty or non-string value.");
|
|
}
|
|
return {
|
|
...cfg,
|
|
gateway: {
|
|
...cfg.gateway,
|
|
auth: {
|
|
...cfg.gateway?.auth,
|
|
password: value.trim(),
|
|
},
|
|
},
|
|
};
|
|
}
|
|
|
|
async function resolveGatewayUrl(
|
|
cfg: OpenClawConfig,
|
|
opts: {
|
|
env: NodeJS.ProcessEnv;
|
|
publicUrl?: string;
|
|
preferRemoteUrl?: boolean;
|
|
forceSecure?: boolean;
|
|
runCommandWithTimeout?: PairingSetupCommandRunner;
|
|
networkInterfaces: () => ReturnType<typeof os.networkInterfaces>;
|
|
},
|
|
): Promise<ResolveUrlResult> {
|
|
const scheme = resolveScheme(cfg, { forceSecure: opts.forceSecure });
|
|
const port = resolveGatewayPort(cfg, opts.env);
|
|
|
|
if (typeof opts.publicUrl === "string" && opts.publicUrl.trim()) {
|
|
const url = normalizeUrl(opts.publicUrl, scheme);
|
|
if (url) {
|
|
return { url, source: "plugins.entries.device-pair.config.publicUrl" };
|
|
}
|
|
return { error: "Configured publicUrl is invalid." };
|
|
}
|
|
|
|
const remoteUrlRaw = cfg.gateway?.remote?.url;
|
|
const remoteUrl =
|
|
typeof remoteUrlRaw === "string" && remoteUrlRaw.trim()
|
|
? normalizeUrl(remoteUrlRaw, scheme)
|
|
: null;
|
|
if (opts.preferRemoteUrl && remoteUrl) {
|
|
return { url: remoteUrl, source: "gateway.remote.url" };
|
|
}
|
|
|
|
const tailscaleMode = cfg.gateway?.tailscale?.mode ?? "off";
|
|
if (tailscaleMode === "serve" || tailscaleMode === "funnel") {
|
|
const host = await resolveTailnetHostWithRunner(opts.runCommandWithTimeout);
|
|
if (!host) {
|
|
return { error: "Tailscale Serve is enabled, but MagicDNS could not be resolved." };
|
|
}
|
|
return { url: `wss://${host}`, source: `gateway.tailscale.mode=${tailscaleMode}` };
|
|
}
|
|
|
|
if (remoteUrl) {
|
|
return { url: remoteUrl, source: "gateway.remote.url" };
|
|
}
|
|
|
|
const bindResult = resolveGatewayBindUrl({
|
|
bind: cfg.gateway?.bind,
|
|
customBindHost: cfg.gateway?.customBindHost,
|
|
scheme,
|
|
port,
|
|
pickTailnetHost: () => pickTailnetIPv4(opts.networkInterfaces),
|
|
pickLanHost: () => pickLanIPv4(opts.networkInterfaces),
|
|
});
|
|
if (bindResult) {
|
|
return bindResult;
|
|
}
|
|
|
|
return {
|
|
error:
|
|
"Gateway is only bound to loopback. Set gateway.bind=lan, enable tailscale serve, or configure plugins.entries.device-pair.config.publicUrl.",
|
|
};
|
|
}
|
|
|
|
export function encodePairingSetupCode(payload: PairingSetupPayload): string {
|
|
const json = JSON.stringify(payload);
|
|
const base64 = Buffer.from(json, "utf8").toString("base64");
|
|
return base64.replace(/\+/g, "-").replace(/\//g, "_").replace(/=+$/g, "");
|
|
}
|
|
|
|
export async function resolvePairingSetupFromConfig(
|
|
cfg: OpenClawConfig,
|
|
options: ResolvePairingSetupOptions = {},
|
|
): Promise<PairingSetupResolution> {
|
|
const env = options.env ?? process.env;
|
|
const cfgForAuth = await resolveGatewayPasswordSecretRef(cfg, env);
|
|
const auth = resolveAuth(cfgForAuth, env);
|
|
if (auth.error) {
|
|
return { ok: false, error: auth.error };
|
|
}
|
|
|
|
const urlResult = await resolveGatewayUrl(cfgForAuth, {
|
|
env,
|
|
publicUrl: options.publicUrl,
|
|
preferRemoteUrl: options.preferRemoteUrl,
|
|
forceSecure: options.forceSecure,
|
|
runCommandWithTimeout: options.runCommandWithTimeout,
|
|
networkInterfaces: options.networkInterfaces ?? os.networkInterfaces,
|
|
});
|
|
|
|
if (!urlResult.url) {
|
|
return { ok: false, error: urlResult.error ?? "Gateway URL unavailable." };
|
|
}
|
|
|
|
if (!auth.label) {
|
|
return { ok: false, error: "Gateway auth is not configured (no token or password)." };
|
|
}
|
|
|
|
return {
|
|
ok: true,
|
|
payload: {
|
|
url: urlResult.url,
|
|
token: auth.token,
|
|
password: auth.password,
|
|
},
|
|
authLabel: auth.label,
|
|
urlSource: urlResult.source ?? "unknown",
|
|
};
|
|
}
|