admin/Moltbot
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

refactor(gateway): dedupe legacy migration validation assertions

Browse Source
This commit is contained in:
Peter Steinberger
2026-03-07 17:28:00 +00:00
parent f7a7f08e15
commit 0de6778f13
1 changed files with 37 additions and 62 deletions
Download Patch File Download Diff File Expand all files Collapse all files

99
src/gateway/server.legacy-migration.test.ts
View File

@@ -8,76 +8,51 @@ import {
installGatewayTestHooks({ scope: "suite" });
async function expectHeartbeatValidationError(legacyParsed: Record<string, unknown>) {
testState.legacyIssues = [
{
path: "heartbeat",
message:
"top-level heartbeat is not a valid config path; use agents.defaults.heartbeat (cadence/target/model settings) or channels.defaults.heartbeat (showOk/showAlerts/useIndicator).",
},
];
testState.legacyParsed = legacyParsed;
testState.migrationConfig = null;
testState.migrationChanges = [];
let server: Awaited<ReturnType<typeof startGatewayServer>> | undefined;
let thrown: unknown;
try {
server = await startGatewayServer(await getFreePort());
} catch (err) {
thrown = err;
}
if (server) {
await server.close();
}
expect(thrown).toBeInstanceOf(Error);
const message = String((thrown as Error).message);
expect(message).toContain("Invalid config at");
expect(message).toContain(
"heartbeat: top-level heartbeat is not a valid config path; use agents.defaults.heartbeat (cadence/target/model settings) or channels.defaults.heartbeat (showOk/showAlerts/useIndicator).",
);
expect(message).not.toContain("Legacy config entries detected but auto-migration failed.");
}
describe("gateway startup legacy migration fallback", () => {
test("surfaces detailed validation errors when legacy entries have no migration output", async () => {
testState.legacyIssues = [
{
path: "heartbeat",
message:
"top-level heartbeat is not a valid config path; use agents.defaults.heartbeat (cadence/target/model settings) or channels.defaults.heartbeat (showOk/showAlerts/useIndicator).",
},
];
testState.legacyParsed = {
await expectHeartbeatValidationError({
heartbeat: { model: "anthropic/claude-3-5-haiku-20241022", every: "30m" },
};
testState.migrationConfig = null;
testState.migrationChanges = [];
let server: Awaited<ReturnType<typeof startGatewayServer>> | undefined;
let thrown: unknown;
try {
server = await startGatewayServer(await getFreePort());
} catch (err) {
thrown = err;
}
if (server) {
await server.close();
}
expect(thrown).toBeInstanceOf(Error);
const message = String((thrown as Error).message);
expect(message).toContain("Invalid config at");
expect(message).toContain(
"heartbeat: top-level heartbeat is not a valid config path; use agents.defaults.heartbeat (cadence/target/model settings) or channels.defaults.heartbeat (showOk/showAlerts/useIndicator).",
);
expect(message).not.toContain("Legacy config entries detected but auto-migration failed.");
});
});
test("keeps detailed validation errors when heartbeat comes from include-resolved config", async () => {
testState.legacyIssues = [
{
path: "heartbeat",
message:
"top-level heartbeat is not a valid config path; use agents.defaults.heartbeat (cadence/target/model settings) or channels.defaults.heartbeat (showOk/showAlerts/useIndicator).",
},
];
// Simulate a parsed source that only contains include directives, while
// legacy heartbeat is surfaced from the resolved config.
testState.legacyParsed = {
await expectHeartbeatValidationError({
$include: ["heartbeat.defaults.json"],
};
testState.migrationConfig = null;
testState.migrationChanges = [];
let server: Awaited<ReturnType<typeof startGatewayServer>> | undefined;
let thrown: unknown;
try {
server = await startGatewayServer(await getFreePort());
} catch (err) {
thrown = err;
}
if (server) {
await server.close();
}
expect(thrown).toBeInstanceOf(Error);
const message = String((thrown as Error).message);
expect(message).toContain("Invalid config at");
expect(message).toContain(
"heartbeat: top-level heartbeat is not a valid config path; use agents.defaults.heartbeat (cadence/target/model settings) or channels.defaults.heartbeat (showOk/showAlerts/useIndicator).",
);
expect(message).not.toContain("Legacy config entries detected but auto-migration failed.");
});
});
});