test(agents): dedupe agent-path fixtures and cover env override precedence
This commit is contained in:
@@ -1,56 +1,85 @@
|
||||
import fs from "node:fs/promises";
|
||||
import os from "node:os";
|
||||
import path from "node:path";
|
||||
import { afterEach, describe, expect, it } from "vitest";
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { withEnv } from "../test-utils/env.js";
|
||||
import { resolveOpenClawAgentDir } from "./agent-paths.js";
|
||||
|
||||
describe("resolveOpenClawAgentDir", () => {
|
||||
let tempStateDir: string | null = null;
|
||||
|
||||
afterEach(async () => {
|
||||
if (tempStateDir) {
|
||||
await fs.rm(tempStateDir, { recursive: true, force: true });
|
||||
tempStateDir = null;
|
||||
const withTempStateDir = async (run: (stateDir: string) => void) => {
|
||||
const stateDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-agent-"));
|
||||
try {
|
||||
run(stateDir);
|
||||
} finally {
|
||||
await fs.rm(stateDir, { recursive: true, force: true });
|
||||
}
|
||||
});
|
||||
};
|
||||
|
||||
it("defaults to the multi-agent path when no overrides are set", async () => {
|
||||
tempStateDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-agent-"));
|
||||
const stateDir = tempStateDir;
|
||||
if (!stateDir) {
|
||||
throw new Error("expected temp state dir");
|
||||
}
|
||||
withEnv(
|
||||
{
|
||||
OPENCLAW_STATE_DIR: stateDir,
|
||||
OPENCLAW_AGENT_DIR: undefined,
|
||||
PI_CODING_AGENT_DIR: undefined,
|
||||
},
|
||||
() => {
|
||||
const resolved = resolveOpenClawAgentDir();
|
||||
expect(resolved).toBe(path.join(stateDir, "agents", "main", "agent"));
|
||||
},
|
||||
);
|
||||
await withTempStateDir((stateDir) => {
|
||||
withEnv(
|
||||
{
|
||||
OPENCLAW_STATE_DIR: stateDir,
|
||||
OPENCLAW_AGENT_DIR: undefined,
|
||||
PI_CODING_AGENT_DIR: undefined,
|
||||
},
|
||||
() => {
|
||||
const resolved = resolveOpenClawAgentDir();
|
||||
expect(resolved).toBe(path.join(stateDir, "agents", "main", "agent"));
|
||||
},
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
it("honors OPENCLAW_AGENT_DIR overrides", async () => {
|
||||
tempStateDir = await fs.mkdtemp(path.join(os.tmpdir(), "openclaw-agent-"));
|
||||
const stateDir = tempStateDir;
|
||||
if (!stateDir) {
|
||||
throw new Error("expected temp state dir");
|
||||
}
|
||||
const override = path.join(stateDir, "agent");
|
||||
withEnv(
|
||||
{
|
||||
OPENCLAW_STATE_DIR: undefined,
|
||||
OPENCLAW_AGENT_DIR: override,
|
||||
PI_CODING_AGENT_DIR: undefined,
|
||||
},
|
||||
() => {
|
||||
const resolved = resolveOpenClawAgentDir();
|
||||
expect(resolved).toBe(path.resolve(override));
|
||||
},
|
||||
);
|
||||
await withTempStateDir((stateDir) => {
|
||||
const override = path.join(stateDir, "agent");
|
||||
withEnv(
|
||||
{
|
||||
OPENCLAW_STATE_DIR: undefined,
|
||||
OPENCLAW_AGENT_DIR: override,
|
||||
PI_CODING_AGENT_DIR: undefined,
|
||||
},
|
||||
() => {
|
||||
const resolved = resolveOpenClawAgentDir();
|
||||
expect(resolved).toBe(path.resolve(override));
|
||||
},
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
it("honors PI_CODING_AGENT_DIR when OPENCLAW_AGENT_DIR is unset", async () => {
|
||||
await withTempStateDir((stateDir) => {
|
||||
const override = path.join(stateDir, "pi-agent");
|
||||
withEnv(
|
||||
{
|
||||
OPENCLAW_STATE_DIR: undefined,
|
||||
OPENCLAW_AGENT_DIR: undefined,
|
||||
PI_CODING_AGENT_DIR: override,
|
||||
},
|
||||
() => {
|
||||
const resolved = resolveOpenClawAgentDir();
|
||||
expect(resolved).toBe(path.resolve(override));
|
||||
},
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
it("prefers OPENCLAW_AGENT_DIR over PI_CODING_AGENT_DIR when both are set", async () => {
|
||||
await withTempStateDir((stateDir) => {
|
||||
const primaryOverride = path.join(stateDir, "primary-agent");
|
||||
const fallbackOverride = path.join(stateDir, "fallback-agent");
|
||||
withEnv(
|
||||
{
|
||||
OPENCLAW_STATE_DIR: undefined,
|
||||
OPENCLAW_AGENT_DIR: primaryOverride,
|
||||
PI_CODING_AGENT_DIR: fallbackOverride,
|
||||
},
|
||||
() => {
|
||||
const resolved = resolveOpenClawAgentDir();
|
||||
expect(resolved).toBe(path.resolve(primaryOverride));
|
||||
},
|
||||
);
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user